106 replies to this topic

[matortheeternal]

I would just use an if-then statement to check if the flag is set and then switch the variable type, but I have no idea if you can do that with your code.

 

I'd have to design a special case or something, it just seems annoying.  An element at a path should be the same type regardless of other elements.  :/

 

Edit:

I think the best solution is to just check if the type of the destination element and the type of the source element match.  If they don't then don't copy.

Edited by matortheeternal, 06 September 2014 - 01:52 AM.

[Lord Garon]

...

I probably have to see the LCTN records to know what you're talking about.  Perhaps a screenshot? 

 

Edit: I think I may have fixed the ITM issue.  We'll see.

 

 

-Mator

 

 

I'm under the impression that ACPR thru LCEP sub-records will merge across all plugins at load time and do not need "patching", hence the skip LCTN sub-record entries in the Mator Smash script. I was just curious why the script created a LCTN record in the patch if the only LCTN changes across the plugin stream were "skipped" sub-records.

 

(Geez, cannot get an image link to display properly. Try Nexus itself...)

 

EDIT: BTW, I notice you are on TES5Edit 3.0.33. I'm on 3.0.32, the current Nexus mod version. Is this an issue?

EDIT2: I would be happy to run the ITM "fix" version, if available. Just let me know where to find it. DOH! Nvm.

Edited by Lord Garon, 06 September 2014 - 03:49 AM.

[fireundubh]

 

I would just use an if-then statement to check if the flag is set and then switch the variable type, but I have no idea if you can do that with your code.

 

I'd have to design a special case or something, it just seems annoying.  An element at a path should be the same type regardless of other elements.  :/

 

Edit:

I think the best solution is to just check if the type of the destination element and the type of the source element match.  If they don't then don't copy.

 

 

Then how are you going to handle the PC Level Mult flag? It sounds like you're going to ignore it, which is going to break stuff.

[matortheeternal]

Then how are you going to handle the PC Level Mult flag? It sounds like you're going to ignore it, which is going to break stuff.

 

Isn't that an entirely separate question?  I'll be making a function to handle flags at some point in the future, but for now I'm just concerned with making it so a crippling error doesn't occur.

 

 

 

...

I probably have to see the LCTN records to know what you're talking about.  Perhaps a screenshot? 

 

Edit: I think I may have fixed the ITM issue.  We'll see.

 

 

-Mator

 

 

I'm under the impression that ACPR thru LCEP sub-records will merge across all plugins at load time and do not need "patching", hence the skip LCTN sub-record entries in the Mator Smash script. I was just curious why the script created a LCTN record in the patch if the only LCTN changes across the plugin stream were "skipped" sub-records.

 

(Geez, cannot get an image link to display properly. Try Nexus itself...)

 

EDIT: BTW, I notice you are on TES5Edit 3.0.33. I'm on 3.0.32, the current Nexus mod version. Is this an issue?

EDIT2: I would be happy to run the ITM "fix" version, if available. Just let me know where to find it. DOH! Nvm.

 

 

As I said before, the script doesn't handle that sort of thing correctly yet.

 

Use 3.0.33.  It's better in every way.

Edited by matortheeternal, 06 September 2014 - 06:19 AM.

[fireundubh]

 

Then how are you going to handle the PC Level Mult flag? It sounds like you're going to ignore it, which is going to break stuff.

 

Isn't that an entirely separate question?  I'll be making a function to handle flags at some point in the future, but for now I'm just concerned with making it so a crippling error doesn't occur.

 

 

I'm trying to visualize your solution but I'm getting lost in the logic. Too much is happening. Is it going to work?

[Lord Garon]

...

 

...

I probably have to see the LCTN records to know what you're talking about.  Perhaps a screenshot? 

 

Edit: I think I may have fixed the ITM issue.  We'll see.

 

 

-Mator

 

--image snip--

 

I'm under the impression that ACPR thru LCEP sub-records will merge across all plugins at load time and do not need "patching", hence the skip LCTN sub-record entries in the Mator Smash script. I was just curious why the script created a LCTN record in the patch if the only LCTN changes across the plugin stream were "skipped" sub-records.

 

...

 

EDIT: BTW, I notice you are on TES5Edit 3.0.33. I'm on 3.0.32, the current Nexus mod version. Is this an issue?

 

As I said before, the script doesn't handle that sort of thing correctly yet.

 

Use 3.0.33.  It's better in every way.

 

 

Sorry, somehow missed that.

Will get 3.0.33.

[Lord Garon]

@Mator

 

Running 3.0.33 on newly cleaned vanilla setup. SmashedPatch for current test plugins (Incon + CRF) appear identical. 3.0.33 cleans the SmashedPatch somewhat differently (154 ITM vs 110 in 3.0.32), but previous reports still seem valid, in general.

 

Just an FYI.   

[matortheeternal]

I'm trying to visualize your solution but I'm getting lost in the logic. Too much is happening. Is it going to work?

 

I haven't decided how I want to actually handle conflicts with this particular element yet.  A previous request I had was to just let the non-IDM winning override of the ACBS element through, and not conflict resolve individual subrecords in it.  That seems to make the most sense to me right now.

 

@Mator

 

Running 3.0.33 on newly cleaned vanilla setup. SmashedPatch for current test plugins (Incon + CRF) appear identical. 3.0.33 cleans the SmashedPatch somewhat differently (154 ITM vs 110 in 3.0.32), but previous reports still seem valid, in general.

 

Just an FYI.   

 

3.0.33's changes don't help with how Mator Smash executes, per say.  The changes are more general.  New scripting functions (which will be required in v0.8 of Mator Smash), fixed memory leaks, faster script execution times, etc. 

[Lord Garon]

@Mator

 

A quick question before I move on to different plugins...

 

I (think I) understand that the current script version will generate some "extra" records in the SmashedPatch. Are you interested in errors in those "extra" records? (Yes or no is fine.) That is, even though there may be extra records, should the script still treat them as normal and apply the changes from prior plugins in the manner you described in earlier posts?

 

I ask this since some of the "extra" records contain prior plugin edits that match your description of how the script "decides" what to include, but there are some extra records which do not receive all the, apparently valid, prior edits.

 

EDIT: grammar

Edited by Lord Garon, 07 September 2014 - 03:01 AM.

[fireundubh]

Script went boom on a record in Guard Dialogue Overhaul: Found a VTYP reference, expected: RACE.

Smashing record [INFO:00087938] ('What do you want, cat?' in GRUP Topic Children of DialogueGenericHello "DialogueGenericHello" [DIAL:000142B5]) from file: Guard Dialogue Overhaul.esp
[Apply Script done]  Processed Records: 0, Elapsed Time: 11:10