106 replies to this topic

[zilav]

Please run check for errors on this record, and post screenshot of problematic elements. I don't have time myself to download mods and test them.

[fireundubh]

Please run check for errors on this record, and post screenshot of problematic elements. I don't have time myself to download mods and test them.

 

Nothing wrong with the plugin other than an unresolvable keyword in a WEAP record.

 

Mator Smash is failing on this condition:

 

 

I would guess that Mator Smash is copying GetPCIsRace (from the USKP, which is not shown here) to the smashed patch and then trying to copy MaleNord [VTYP:00013AE6].

Edited by fireundubh, 07 September 2014 - 10:31 AM.

[zilav]

Seems so, conditions and their fields should not be merged.

[Lord Garon]

 

Script went boom on a record in Guard Dialogue Overhaul: Found a VTYP reference, expected: RACE.

Smashing record [INFO:00087938] ('What do you want, cat?' in GRUP Topic Children of DialogueGenericHello "DialogueGenericHello" [DIAL:000142B5]) from file: Guard Dialogue Overhaul.esp
[Apply Script done]  Processed Records: 0, Elapsed Time: 11:10

 

Logged in to post Script Report of exact same error, so I can verify the issue.

Edited by Lord Garon, 07 September 2014 - 04:02 PM.

[matortheeternal]

Seems so, conditions and their fields should not be merged.

 

Are Conditions sorted?  If not, then it makes total sense to me why this is happening.

So Conditions need to be fully skipped?  Hmm.  Hopefully that won't be too crippling.

[fireundubh]

When I add these signatures to the skip lists, Mator Smash slows down to a crawl, especially on RACE records for some reason but overall, too:
 

  signaturesToSkip = 'NAVM'#13'NAVI'#13'DOBJ'#13'DIAL'#13'INFO'#13'CELL'#13'WRLD'#13'REFR'#13'ACHR'#13'QUST';
  subrecordsToSkip = 
    'NPC_ \ ACBS - Configuration'#13
    'NPC_ \ QNAM - Texture lighting'#13
    'NPC_ \ NAM9 - Face morph'#13
    'NPC_ \ NAMA - Face parts'#13
    'NPC_ \ Tint Layers'#13
    'DIAL \ TIFC - Info Count'#13
    'INFO \ PNAM - Previous INFO'#13

[Lord Garon]

Mator Smash Script Report MS0301

TES5Edit version: 3.0.33
Mator Smash version: 0.7+beta2
Result: xEdit plugin "Check for Errors" produced NPC_ errors
Script/xEdit Error: none
Plugins Smashed: Entire load order (see below)
TES5Edit Message Log: (see below)
Resulting Smashed Patch:
Notes:
1. Bethesda files exhibit same ARMO record errors.
2. NPC_ records: screenshot (Ulfric) below. Anomalous sub-record (DNAM) structure.
3. Still checking other errors

Load Order:

Spoiler

# Slightly tweaked LOOT order
# Unusual plugins are either optimized content or dummy BSA loaders
Skyrim.esm
Update.esm
Unofficial Skyrim Patch.esp
Dawnguard.esm
Unofficial Dawnguard Patch.esp
Hearthfires.esm
Unofficial Hearthfire Patch.esp
Dragonborn.esm
Unofficial Dragonborn Patch.esp
Skyrim Project Optimization - Full Version.esm
ClimatesOfTamriel.esm
SPIKE.esm
ETaC - RESOURCES.esm
WinterholdDestruction.esm
HRDLC1.esp
HRDLC2.esp
HRDLC3.esp
Cutting Room Floor.esp
SkyUI.esp
ClimatesOfTamriel-Dawnguard-Patch.esp
ClimatesOfTamriel-Dragonborn-Patch.esp
CoT-WeatherPatch.esp
CoT-WeatherPatch_DB.esp
Appropriately Attired Jarls Redux.esp
Guard Dialogue Overhaul.esp
Default_Animal_Replacement_BSA.esp
DeadlyDragons.esp
TradeBarter.esp
CharacterMakingExtender.esp
EnhancedCharacterEdit.esp
F02_RCI.esp
ERSO 30.1 - Better Expert Level.esp
Brawl Bugs CE.esp
3DNPC_Sounds.esp
3DNPC_Misc.esp
3DNPC.esp
StaticMeshImprovementMod.esp
ERSO 30 - Better Enemy AI Dawnguard&Dragonborn.esp
ClimatesOfTamriel-Nights-Level-4.esp
fFastTravelSpeedMult_4.esp
Ars Metallica.esp
Ars Metallica - Dawnguard.esp
Ars Metallica - Hearthfire.esp
Ars Metallica - Dragonborn.esp
ExpandedWinterholdRuins.esp
ClimatesOfTamriel-Dungeons-Hazardous.esp
ClimatesOfTamriel-Interiors-Warm.esp
SPTConsistentOlderPeople.esp
ShootingStars.esp
SMIM-DungeonsCliffsIceSkirts.esp
vAutosaveManager.esp
Weapons & Armor Fixes_Remade.esp
Clothing & Clutter Fixes.esp
Inns and Taverns.esp
ETaC - Darkwater Crossing.esp
ETaC - Dawnstar.esp
ETaC - Dragon Bridge.esp
ETaC - Dragon Bridge South.esp
ETaC - Falkreath.esp
ETaC - Ivarstead.esp
ETaC - Karthwasten.esp
ETaC - Karthwasten Inns and Taverns Patch.esp
ETaC - Kynesgrove.esp
ETaC - Morthal.esp
ETaC - Riverwood.esp
ETaC - Rorikstead.esp
ETaC - Winterhold.esp
ETaC - Winterhold EWDR Patch.esp
RealisticNeedsandDiseases.esp
RND_ETaC-Patch.esp
WATER.esp
WATER DG.esp
Rebirth Monster.esp
High Level Enemies - Dragonborn.esp
High Level Enemies.esp
High Level Enemies - Dawnguard.esp
Remodeled Armor - Vanilla Replacer.esp
SkyFalls - Distant Waterfall Overhaul.esp
WATER DB Waves.esp
Inconsequential NPCs.esp
Inconsequential NPCs - CRF Compatibility Patch.esp
Dead Body Collision.esp
SMIM-ShackRoofFixes.esp
Daggercross_Alley.esp
REGS Patch - 3DNPC.esp
SMIM-FarmhouseFlickeringFix.esp
Chesko_Frostfall.esp
SMIM-ShackRoofFixesDragonborn.esp
REGS Patch - RND.esp
Skyrim Flora Overhaul.esp
WATER Plants.esp
Apple garden.esp

TES5Edit message log:

Spoiler

# SmashedPatch03 (All Mods) xEdit: Check for Errors

[00:00] Checking for Errors in [58] SmashedPatch03.esp
[00:00] ArmorIronShield "Iron Shield" [ARMO:00012EB6]
[00:00]     ARMO \ Record Header \ Record Flags -> <Unknown: 6>
[00:00] ArmorImperialShield "Imperial Shield" [ARMO:000135BA]
[00:00]     ARMO \ Record Header \ Record Flags -> <Unknown: 6>
[00:00] ArmorOrcishShield "Orcish Shield" [ARMO:00013946]
[00:00]     ARMO \ Record Header \ Record Flags -> <Unknown: 6>
[00:00] SU02IronShield "Family Shield" [ARMO:0003521F]
[00:00]     ARMO \ Record Header \ Record Flags -> <Unknown: 6>
[00:00] DA13Spellbreaker "Spellbreaker" [ARMO:00045F96]
[00:00]     ARMO \ Record Header \ Record Flags -> <Unknown: 6>
[00:00] Ulfric "Ulfric Stormcloak" [NPC_:0001414D]
[00:00]     NPC_ \ DNAM - Player Skills \ Geared up weapons -> Expected 1 bytes of data, found 0
[00:00] EncBandit04Boss1HImperialF [NPC_:0003DEF2]
[00:00]     NPC_ \ DNAM - Player Skills \ Geared up weapons -> Expected 1 bytes of data, found 0
[00:00] EncBandit04Boss1HImperialM [NPC_:0003DEF3]
[00:00]     NPC_ \ DNAM - Player Skills \ Geared up weapons -> Expected 1 bytes of data, found 0
[00:00] EncBandit04Boss2HNordM [NPC_:0003DEF8]
[00:00]     NPC_ \ DNAM - Player Skills \ Geared up weapons -> Expected 1 bytes of data, found 0
[00:00] EncBandit05Boss1HNordM [NPC_:0003DEFF]
[00:00]     NPC_ \ DNAM - Player Skills \ Geared up weapons -> Expected 1 bytes of data, found 0
[00:00] <Warning: Unused data in:  \ [58] SmashedPatch03.esp \ [13] GRUP Top "DIAL" \ [9] GRUP Topic Children of [DIAL:0002137B] \ [0] [INFO:000479F5] ('It's a wonderful house, my love. If you don't mind, I'm going to start a small store. Something to do whenever you're on the road.' in GRUP Topic Children of [DIAL:0002137B]) \ [2] VMAD - Virtual Machine Adapter>
[00:00] <Warning: Unused data in:  \ [58] SmashedPatch03.esp \ [13] GRUP Top "DIAL" \ [9] GRUP Topic Children of [DIAL:0002137B] \ [0] [INFO:000479F5] ('It's a wonderful house, my love. If you don't mind, I'm going to start a small store. Something to do whenever you're on the road.' in GRUP Topic Children of [DIAL:0002137B]) \ [2] VMAD - Virtual Machine Adapter>
[00:00] RelationshipMarriageFIN [QUST:00021382]
[00:00]     QUST \ VMAD - Virtual Machine Adapter \ Data \ Quest VMAD \ Scripts \ Script \ Properties \ Property \ Value \ Object Union \ Object v2 \ Alias -> <Warning: Quest Alias not found in "RelationshipMarriageFIN [QUST:00021382]">
[00:00]     QUST \ VMAD - Virtual Machine Adapter \ Data \ Quest VMAD \ Scripts \ Script \ Properties \ Property \ Value \ Object Union \ Object v2 \ Alias -> <Warning: Quest Alias not found in "RelationshipMarriageFIN [QUST:00021382]">
[00:00]     QUST \ VMAD - Virtual Machine Adapter \ Data \ Quest VMAD \ Scripts \ Script \ Properties \ Property \ Value \ Object Union \ Object v2 \ Alias -> <Warning: Quest Alias not found in "RelationshipMarriageFIN [QUST:00021382]">
[00:00]     QUST \ VMAD - Virtual Machine Adapter \ Data \ Quest VMAD \ Scripts \ Script \ Properties \ Property \ Value \ Object Union \ Object v2 \ Alias -> <Warning: Quest Alias not found in "RelationshipMarriageFIN [QUST:00021382]">
[00:00]     QUST \ VMAD - Virtual Machine Adapter \ Data \ Quest VMAD \ Scripts \ Script \ Properties \ Property \ Value \ Object Union \ Object v2 \ Alias -> <Warning: Quest Alias not found in "RelationshipMarriageFIN [QUST:00021382]">
[00:00]     QUST \ VMAD - Virtual Machine Adapter \ Data \ Quest VMAD \ Script Fragments Quest \ Aliases \ Alias \ Object Union \ Object v2 \ Alias -> <Warning: Quest Alias not found in "RelationshipMarriageFIN [QUST:00021382]">
[00:00] All Done!

NPC_ / DNAM screenshot:

Spoiler

 

EDIT: Not sure if the NPC_ records even meet Patch criteria (more than 1 non-Beth override) and may be extraneous. Just looking for global errors and the "Check for Errors" found some.

 

UPDATE: Generated test plugins to check SmashedPatch NPC_ handling with >1 overrides. Edited skill lvl only and Health in test plugin records. Smashed DNAM created incorrectly. Prior edits in non-DNAM fields (more likely in an actual patch?) do not cause the problem.

 

UPDATE Screenshot:

Spoiler

Edited by Lord Garon, 08 September 2014 - 12:20 AM.

[Lord Garon]

Mator Smash Script Report MS0304

TES5Edit version: 3.0.33
Mator Smash version: 0.7+beta2
Result: NPC_ \ TINC not forwarding edits correctly
Script/xEdit Error: none
Plugins Smashed: NPC_ Record Test Plugins (Ulfric only)
TES5Edit Message Log:
Screenshot: (see below)
Resulting Smashed Patch:
Notes: Mator identified an NPC \ Tint Layers issue previously; this "seems" different, but may be related.

Screenshot follows:

Spoiler

 

EDIT: An original post was deleted. The post with this EDIT has correct info.

Edited by Lord Garon, 09 September 2014 - 04:25 PM.

[Lord Garon]

Better Late Than Never?

 

I'm not very knowledgeable about all this stuff and would like feedback on my current testing procedure. This is how I'm testing the Mator Script:

1. Check original (cleaned) plugins for errors (in case of carry-over errors).
2. Apply Conflict Filter to identify overrides (FNVEdit Manual - "6" boxes checked filter).
3. Smash plugins.
4. Save any xEdit/script errors.
5. Check SmashedPatch(SP) for Errors.
6. Compare SP to existing Compatibility Patch, if any.
7. Filter for Cleaning - Check ITM's.
8. Line-by-line SP records check (compare to UESP Record descriptions).
9. Generate single record Test Plugins.
10. Edit Test Plugins, check SmashedPatch generation.

 

Critique?

 

EDIT: Would a Bashed_Patch vs SmashedPatch comparison be useful for those records in a Bashed_Patch?

Edited by Lord Garon, 11 September 2014 - 02:55 PM.

[Nyquist]

Just wanted to chime in and say that this is amazing work i hope from the bottom of my heart that this user script will come to fruition