Jump to content

"Repair" script not working 100%


DaiSC

Recommended Posts

Hi all!

 

I'd like to preface this by saying that I have practically no experience using the GECK for anything complicated, but I'm having a problem.

 

I wanted to have a terminal that I can go use to repair everything in the players inventory at once. Not just items with DT (like Leather Armor) but even clothing with no DT (or DR in the game). Because player.srm only repairs items with DT, and even then leads to missing items occassionally in the PipBoy when dealing with multiple copies, I had to write a very simple script to work around it. Here is the script:

short PWeapons
Set PWeapons to (Player.GetItemCount WeapNV357Revolver)
Player.RemoveItem WeapNV357Revolver PWeapons
Player.AddItem WeapNV357Revolver PWeapons
Set PWeapons to (Player.GetItemCount WeapNV44Revolver)
Player.RemoveItem WeapNV44Revolver PWeapons
Player.AddItem WeapNV44Revolver PWeapons
Set PWeapons to (Player.GetItemCount NVDLC02Weap45AutoPistol)
Player.RemoveItem NVDLC02Weap45AutoPistol PWeapons
Player.AddItem NVDLC02Weap45AutoPistol PWeapons
Set PWeapons to (Player.GetItemCount NVDLC02Weap45AutoSubmachineGun)
Player.RemoveItem NVDLC02Weap45AutoSubmachineGun PWeapons
Player.AddItem NVDLC02Weap45AutoSubmachineGun PWeapons
Set PWeapons to (Player.GetItemCount Weap10mmPistol)
Player.RemoveItem Weap10mmPistol PWeapons
Player.AddItem Weap10mmPistol PWeapons
Set PWeapons to (Player.GetItemCount Weap10mmSubmachineGun)
Player.RemoveItem Weap10mmSubmachineGun PWeapons
Player.AddItem Weap10mmSubmachineGun PWeapons
Set PWeapons to (Player.GetItemCount WeapNV127mmPistol)
Player.RemoveItem WeapNV127mmPistol PWeapons
Player.AddItem WeapNV127mmPistol PWeapons
Set PWeapons to (Player.GetItemCount WeapNV127mmSubmachineGun)
Player.RemoveItem WeapNV127mmSubmachineGun PWeapons
Player.AddItem WeapNV127mmSubmachineGun PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapNV127mmSubmachineGunCustom)
Player.RemoveItem NVDLC05WeapNV127mmSubmachineGunCustom PWeapons
Player.AddItem NVDLC05WeapNV127mmSubmachineGunCustom PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05Weap25mmGrenadeAPWCustom)
Player.RemoveItem NVDLC05Weap25mmGrenadeAPWCustom PWeapons
Player.AddItem NVDLC05Weap25mmGrenadeAPWCustom PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapNV556mmPistolCustom)
Player.RemoveItem NVDLC05WeapNV556mmPistolCustom PWeapons
Player.AddItem NVDLC05WeapNV556mmPistolCustom PWeapons
Set PWeapons to (Player.GetItemCount WeapNV9iron)
Player.RemoveItem WeapNV9iron PWeapons
Player.AddItem WeapNV9iron PWeapons
Set PWeapons to (Player.GetItemCount WeapNV9mmPistol)
Player.RemoveItem WeapNV9mmPistol PWeapons
Player.AddItem WeapNV9mmPistol PWeapons
Set PWeapons to (Player.GetItemCount WeapNV9mmSubmachineGun)
Player.RemoveItem WeapNV9mmSubmachineGun PWeapons
Player.AddItem WeapNV9mmSubmachineGun PWeapons
Set PWeapons to (Player.GetItemCount NVDLC02Weap45AutoPistolUnique)
Player.RemoveItem NVDLC02Weap45AutoPistolUnique PWeapons
Player.AddItem NVDLC02Weap45AutoPistolUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapNVBBGunUnique)
Player.RemoveItem WeapNVBBGunUnique PWeapons
Player.AddItem WeapNVBBGunUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapLaserRifleUnique)
Player.RemoveItem WeapLaserRifleUnique PWeapons
Player.AddItem WeapLaserRifleUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapAlienBlaster)
Player.RemoveItem WeapAlienBlaster PWeapons
Player.AddItem WeapAlienBlaster PWeapons
Set PWeapons to (Player.GetItemCount WeapNVMarksmanCarbineUnique)
Player.RemoveItem WeapNVMarksmanCarbineUnique PWeapons
Player.AddItem WeapNVMarksmanCarbineUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapNVMissileLauncherUnique)
Player.RemoveItem WeapNVMissileLauncherUnique PWeapons
Player.AddItem WeapNVMissileLauncherUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapNVAntiMaterielRifle)
Player.RemoveItem WeapNVAntiMaterielRifle PWeapons
Player.AddItem WeapNVAntiMaterielRifle PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapNVAntiMaterielRifleCustom)
Player.RemoveItem NVDLC05WeapNVAntiMaterielRifleCustom PWeapons
Player.AddItem NVDLC05WeapNVAntiMaterielRifleCustom PWeapons
Set PWeapons to (Player.GetItemCount NVDLC04WeapArcWelder)
Player.RemoveItem NVDLC04WeapArcWelder PWeapons
Player.AddItem NVDLC04WeapArcWelder PWeapons
Set PWeapons to (Player.GetItemCount WeapNVAssaultCarbine)
Player.RemoveItem WeapNVAssaultCarbine PWeapons
Player.AddItem WeapNVAssaultCarbine PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapNVAssaultCarbineCustom)
Player.RemoveItem NVDLC05WeapNVAssaultCarbineCustom PWeapons
Player.AddItem NVDLC05WeapNVAssaultCarbineCustom PWeapons
Set PWeapons to (Player.GetItemCount NVDLC01WeapAutomaticRifle)
Player.RemoveItem NVDLC01WeapAutomaticRifle PWeapons
Player.AddItem NVDLC01WeapAutomaticRifle PWeapons
Set PWeapons to (Player.GetItemCount WeapNVBallisticFist)
Player.RemoveItem WeapNVBallisticFist PWeapons
Player.AddItem WeapNVBallisticFist PWeapons
Set PWeapons to (Player.GetItemCount WeapBaseballBat)
Player.RemoveItem WeapBaseballBat PWeapons
Player.AddItem WeapBaseballBat PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapBaseballBatCustom)
Player.RemoveItem NVDLC05WeapBaseballBatCustom PWeapons
Player.AddItem NVDLC05WeapBaseballBatCustom PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapNVBattleRifleCustom)
Player.RemoveItem NVDLC05WeapNVBattleRifleCustom PWeapons
Player.AddItem NVDLC05WeapNVBattleRifleCustom PWeapons
Set PWeapons to (Player.GetItemCount WeapBBGun)
Player.RemoveItem WeapBBGun PWeapons
Player.AddItem WeapBBGun PWeapons
Set PWeapons to (Player.GetItemCount NVDLC01WeapBearTrapFist)
Player.RemoveItem NVDLC01WeapBearTrapFist PWeapons
Player.AddItem NVDLC01WeapBearTrapFist PWeapons
Set PWeapons to (Player.GetItemCount WeapShotgunSawedOffUnique)
Player.RemoveItem WeapShotgunSawedOffUnique PWeapons
Player.AddItem WeapShotgunSawedOffUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapNVBinoculars)
Player.RemoveItem WeapNVBinoculars PWeapons
Player.AddItem WeapNVBinoculars PWeapons
Set PWeapons to (Player.GetItemCount WeapNVLegateSword2)
Player.RemoveItem WeapNVLegateSword2 PWeapons
Player.AddItem WeapNVLegateSword2 PWeapons
Set PWeapons to (Player.GetItemCount NVDLC04WeapBladeWest)
Player.RemoveItem NVDLC04WeapBladeWest PWeapons
Player.AddItem NVDLC04WeapBladeWest PWeapons
Set PWeapons to (Player.GetItemCount WeapBladedGauntlet)
Player.RemoveItem WeapBladedGauntlet PWeapons
Player.AddItem WeapBladedGauntlet PWeapons
Set PWeapons to (Player.GetItemCount NVDLC04WeapBowieKnifeUnique)
Player.RemoveItem NVDLC04WeapBowieKnifeUnique PWeapons
Player.AddItem NVDLC04WeapBowieKnifeUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapMineBottlecap)
Player.RemoveItem WeapMineBottlecap PWeapons
Player.AddItem WeapMineBottlecap PWeapons
Set PWeapons to (Player.GetItemCount NVDLC04WeapBowieKnife)
Player.RemoveItem NVDLC04WeapBowieKnife PWeapons
Player.AddItem NVDLC04WeapBowieKnife PWeapons
Set PWeapons to (Player.GetItemCount WeapNVBoxingGloves)
Player.RemoveItem WeapNVBoxingGloves PWeapons
Player.AddItem WeapNVBoxingGloves PWeapons
Set PWeapons to (Player.GetItemCount WeapNVBoxingTape)
Player.RemoveItem WeapNVBoxingTape PWeapons
Player.AddItem WeapNVBoxingTape PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapNVLightMachineGunUnique)
Player.RemoveItem NVDLC05WeapNVLightMachineGunUnique PWeapons
Player.AddItem NVDLC05WeapNVLightMachineGunUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapBrassKnuckles)
Player.RemoveItem WeapBrassKnuckles PWeapons
Player.AddItem WeapBrassKnuckles PWeapons
Set PWeapons to (Player.GetItemCount WeapPreordMachete)
Player.RemoveItem WeapPreordMachete PWeapons
Player.AddItem WeapPreordMachete PWeapons
Set PWeapons to (Player.GetItemCount WeapNVBrushGun)
Player.RemoveItem WeapNVBrushGun PWeapons
Player.AddItem WeapNVBrushGun PWeapons
Set PWeapons to (Player.GetItemCount WeapNVBumperSword)
Player.RemoveItem WeapNVBumperSword PWeapons
Player.AddItem WeapNVBumperSword PWeapons
Set PWeapons to (Player.GetItemCount WeapNVC4PlasticExplosive)
Player.RemoveItem WeapNVC4PlasticExplosive PWeapons
Player.AddItem WeapNVC4PlasticExplosive PWeapons
Set PWeapons to (Player.GetItemCount WeapNVCaravanShotgun)
Player.RemoveItem WeapNVCaravanShotgun PWeapons
Player.AddItem WeapNVCaravanShotgun PWeapons
Set PWeapons to (Player.GetItemCount WeapCattleProd)
Player.RemoveItem WeapCattleProd PWeapons
Player.AddItem WeapCattleProd PWeapons
Set PWeapons to (Player.GetItemCount WeapNVChainsaw)
Player.RemoveItem WeapNVChainsaw PWeapons
Player.AddItem WeapNVChainsaw PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapNVChainsawCustom)
Player.RemoveItem NVDLC05WeapNVChainsawCustom PWeapons
Player.AddItem NVDLC05WeapNVChainsawCustom PWeapons
Set PWeapons to (Player.GetItemCount WeapNVKnifeCombatUnique)
Player.RemoveItem WeapNVKnifeCombatUnique PWeapons
Player.AddItem WeapNVKnifeCombatUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapNVCleaverUnique)
Player.RemoveItem WeapNVCleaverUnique PWeapons
Player.AddItem WeapNVCleaverUnique PWeapons
Set PWeapons to (Player.GetItemCount NVDLC03WeapSniperRifleUniqueChristine)
Player.RemoveItem NVDLC03WeapSniperRifleUniqueChristine PWeapons
Player.AddItem NVDLC03WeapSniperRifleUniqueChristine PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapFlamerUnique)
Player.RemoveItem NVDLC05WeapFlamerUnique PWeapons
Player.AddItem NVDLC05WeapFlamerUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapNVCleaver)
Player.RemoveItem WeapNVCleaver PWeapons
Player.AddItem WeapNVCleaver PWeapons
Set PWeapons to (Player.GetItemCount NVWeapMS22Camera)
Player.RemoveItem NVWeapMS22Camera PWeapons
Player.AddItem NVWeapMS22Camera PWeapons
Set PWeapons to (Player.GetItemCount WeapKnifeCombat)
Player.RemoveItem WeapKnifeCombat PWeapons
Player.AddItem WeapKnifeCombat PWeapons
Set PWeapons to (Player.GetItemCount NVDLC02WeapComplianceRegulator)
Player.RemoveItem NVDLC02WeapComplianceRegulator PWeapons
Player.AddItem NVDLC02WeapComplianceRegulator PWeapons
Set PWeapons to (Player.GetItemCount NVDLC03WeapGlovesCorrosive)
Player.RemoveItem NVDLC03WeapGlovesCorrosive PWeapons
Player.AddItem NVDLC03WeapGlovesCorrosive PWeapons
Set PWeapons to (Player.GetItemCount NVDLC01WeapSpaceAgeKnife)
Player.RemoveItem NVDLC01WeapSpaceAgeKnife PWeapons
Player.AddItem NVDLC01WeapSpaceAgeKnife PWeapons
Set PWeapons to (Player.GetItemCount NVDLC01WeapSpaceAgeKnifeClean)
Player.RemoveItem NVDLC01WeapSpaceAgeKnifeClean PWeapons
Player.AddItem NVDLC01WeapSpaceAgeKnifeClean PWeapons
Set PWeapons to (Player.GetItemCount NVDLC01WeapSpaceAgeKnifeHeated)
Player.RemoveItem NVDLC01WeapSpaceAgeKnifeHeated PWeapons
Player.AddItem NVDLC01WeapSpaceAgeKnifeHeated PWeapons
Set PWeapons to (Player.GetItemCount WeapNVCowboyRepeater)
Player.RemoveItem WeapNVCowboyRepeater PWeapons
Player.AddItem WeapNVCowboyRepeater PWeapons
Set PWeapons to (Player.GetItemCount WeapBladedGauntletUnique)
Player.RemoveItem WeapBladedGauntletUnique PWeapons
Player.AddItem WeapBladedGauntletUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapNVMinigunUnique)
Player.RemoveItem WeapNVMinigunUnique PWeapons
Player.AddItem WeapNVMinigunUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapDeathclawGauntlet)
Player.RemoveItem WeapDeathclawGauntlet PWeapons
Player.AddItem WeapDeathclawGauntlet PWeapons
Set PWeapons to (Player.GetItemCount NVDLC01WeapDemoCharge)
Player.RemoveItem NVDLC01WeapDemoCharge PWeapons
Player.AddItem NVDLC01WeapDemoCharge PWeapons
Set PWeapons to (Player.GetItemCount WeapNVDetonator)
Player.RemoveItem WeapNVDetonator PWeapons
Player.AddItem WeapNVDetonator PWeapons
Set PWeapons to (Player.GetItemCount WeapNVHuntingShotgunUnique)
Player.RemoveItem WeapNVHuntingShotgunUnique PWeapons
Player.AddItem WeapNVHuntingShotgunUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapNVDisplacerGlove)
Player.RemoveItem WeapNVDisplacerGlove PWeapons
Player.AddItem WeapNVDisplacerGlove PWeapons
Set PWeapons to (Player.GetItemCount WeapNVDogTagFist)
Player.RemoveItem WeapNVDogTagFist PWeapons
Player.AddItem WeapNVDogTagFist PWeapons
Set PWeapons to (Player.GetItemCount NVDLC03WeapGlovesDrKleinL)
Player.RemoveItem NVDLC03WeapGlovesDrKleinL PWeapons
Player.AddItem NVDLC03WeapGlovesDrKleinL PWeapons
Set PWeapons to (Player.GetItemCount NVDLC03WeapGlovesDrMobiusL)
Player.RemoveItem NVDLC03WeapGlovesDrMobiusL PWeapons
Player.AddItem NVDLC03WeapGlovesDrMobiusL PWeapons
Set PWeapons to (Player.GetItemCount WeapNVDressCane)
Player.RemoveItem WeapNVDressCane PWeapons
Player.AddItem WeapNVDressCane PWeapons
Set PWeapons to (Player.GetItemCount WeapNVDynamite)
Player.RemoveItem WeapNVDynamite PWeapons
Player.AddItem WeapNVDynamite PWeapons
Set PWeapons to (Player.GetItemCount NVDLC03WeapLaerUniqueElijah)
Player.RemoveItem NVDLC03WeapLaerUniqueElijah PWeapons
Player.AddItem NVDLC03WeapLaerUniqueElijah PWeapons
Set PWeapons to (Player.GetItemCount NVDLC03WeapTeslaCannonUniqueElijah)
Player.RemoveItem NVDLC03WeapTeslaCannonUniqueElijah PWeapons
Player.AddItem NVDLC03WeapTeslaCannonUniqueElijah PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapNVMantisGauntletUnique)
Player.RemoveItem NVDLC05WeapNVMantisGauntletUnique PWeapons
Player.AddItem NVDLC05WeapNVMantisGauntletUnique PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapFatmanUnique)
Player.RemoveItem NVDLC05WeapFatmanUnique PWeapons
Player.AddItem NVDLC05WeapFatmanUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapNVEuclidsCFinder)
Player.RemoveItem WeapNVEuclidsCFinder PWeapons
Player.AddItem WeapNVEuclidsCFinder PWeapons
Set PWeapons to (Player.GetItemCount WeapFatman)
Player.RemoveItem WeapFatman PWeapons
Player.AddItem WeapFatman PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapFatmanCustom)
Player.RemoveItem NVDLC05WeapFatmanCustom PWeapons
Player.AddItem NVDLC05WeapFatmanCustom PWeapons
Set PWeapons to (Player.GetItemCount NVDLC05WeapMineFat)
Player.RemoveItem NVDLC05WeapMineFat PWeapons
Player.AddItem NVDLC05WeapMineFat PWeapons
Set PWeapons to (Player.GetItemCount NVDLC03WeapCyberdogGunFido)
Player.RemoveItem NVDLC03WeapCyberdogGunFido PWeapons
Player.AddItem NVDLC03WeapCyberdogGunFido PWeapons
Set PWeapons to (Player.GetItemCount WeapNVStraightRazorUnique)
Player.RemoveItem WeapNVStraightRazorUnique PWeapons
Player.AddItem WeapNVStraightRazorUnique PWeapons
Set PWeapons to (Player.GetItemCount WeapNVFireaxe)
Player.RemoveItem WeapNVFireaxe PWeapons
Player.AddItem WeapNVFireaxe PWeapons
Set PWeapons to (Player.GetItemCount NVDLC02WeapFireBomb)
Player.RemoveItem NVDLC02WeapFireBomb PWeapons
Player.AddItem NVDLC02WeapFireBomb PWeapons
Set PWeapons to (Player.GetItemCount NVDLC04WeapDeathclawGauntletUnique)
Player.RemoveItem NVDLC04WeapDeathclawGauntletUnique PWeapons
Player.AddItem NVDLC04WeapDeathclawGauntletUnique PWeapons
Set PWeapons to (Player.GetItemCount NVDLC04WeapDeathclawGauntletUniqueWildWasteland)
Player.RemoveItem NVDLC04WeapDeathclawGauntletUniqueWildWasteland PWeapons
Player.AddItem NVDLC04WeapDeathclawGauntletUniqueWildWasteland PWeapons
Set PWeapons to (Player.GetItemCount WeapFlamer)
Player.RemoveItem WeapFlamer PWeapons
Player.AddItem WeapFlamer PWeapons
Set PWeapons to (Player.GetItemCount NVDLC04weapflaregun)
Player.RemoveItem NVDLC04weapflaregun PWeapons
Player.AddItem NVDLC04weapflaregun PWeapons
Set PWeapons to (Player.GetItemCount NVDLC04WeapGrenadeFlashBang)
Player.RemoveItem NVDLC04WeapGrenadeFlashBang PWeapons
Player.AddItem NVDLC04WeapGrenadeFlashBang PWeapons
Set PWeapons to (Player.GetItemCount WeapGrenadeFrag)
Player.RemoveItem WeapGrenadeFrag PWeapons
Player.AddItem WeapGrenadeFrag PWeapons

I have done this for every piece of apparel and weapon in the game (that you can acquire) and have had to split this up into different terminal entries because there is a character limit on the result script in a terminal.

 

The problem is that when I use my terminal, the functions of the script work (it counts, then removes, then adds) for about 90% of what I have written. Some items never get touched even though they are in the script. I have double checked the ID's in the GECK and they are correct. The exact items in the players inventory are also in the script, yet they are never picked up by the script. Now, there are 6 of these entries on the terminal (because of the character limits) that encompass every equippable item in the game. Do I need to split the scripts even more? The script is coming up to the character limit on the result script for each terminal entry. Should I trim and add another entry to reduce the characters in the current entries?

 

I'm not sure what to do and why this isn't working.

 

Any ideas?

 

Thanks for reading...

 

Dai.

Link to comment
Share on other sites

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...