Daggerfall unity support

[Excoriated]

Hi,
hope this is the right place for this.

I noticed that the Daggerfall Unity support in Vortex is lacking. So I wrote a custom extension that fixes this. But this means it will show up as a game variant in the Games tab in Vortex with a "Community" label.

I was wondering if the OG dev could implement the fix to the build in extension for Daggerfall Unity.

Here's the fix in the install method:

if (path.dirname(file).toLowerCase().indexOf('windows') !== -1) {		  
  let targetPath;

  if(path.dirname(file).toLowerCase().indexOf('mods') !== -1)
  {
    targetPath = path.basename(file);
  }
  else
  {
    targetPath = path.join('Mods', path.basename(file));
  }
  // This is the dfmod we want to install.
  result.instructions.push({
    type: 'copy',
    source: file,
    destination: targetPath,
  });
}

Since some modders put their .dfmod files at the root of the zip, they can't be installed via Vortex. This fix checks if this is the case and makes it so the target directory is /mods.

I will upload this as a community extension to Nexus, afaik this will get used over the build in one, if the priority is higher, right?

[ChemBoy1]

Make a PR for the Daggerfall Unity extension with your changes: https://github.com/Nexus-Mods/vortex-games/pulls

Vortex devs won't approve a separate extension with only a single installer bugfix.

[Excoriated]

Quote

Please note: we are no longer accepting pull requests to this repo. Please use our website to distribute your extensions instead. More on how to do this here: https://modding.wiki/en/vortex/developer/packaging-extensions

Uhhh is this true?

[ChemBoy1]

That is a very old message that means they are not adding new extensions to that repo. They are added to the site now. You can make PRs to fix bugs in existing extensions. I already have and was specifically invited to do so by the current main Vortex developer, Nagev. 

Some of the extensions are built from TypeScript. If that were the case (it's not for this one), Nagev may need to make the changes himself rather than directly merging your PR. 

[Excoriated]

Alright, thank you very much