Jump to content

[LE] How the hell do i Script this ?

maxarturo

By maxarturo
in Creation Kit and Modders

 Share

Recommended Posts

maxarturo Grand Master

maxarturo

Posted
Posted (edited)
I want to attach a simple "secondary" script to the final BOSS that when his health reaches 50% or below 50% will fire and enable a Link Ref - trigger box.


Sounds simple but... i want to use "percentage" and not "set actor health value", the main reason behind this is that, i'm taking in account the different mods that changes the NPCs level and health like "Run Dragonborn Run" and many other mods like this.


What's the logic behind the creation of such script ?.


* I don't want to attach this to my main script, because it will also be use with an other boss with different "Primary" script.

* creationkit.com hasn't been very helpful with this one.

* I'm researching this before i finish the final cell. I still have a lot of work...

* Please let it not be one of those things that can't be done.... Again....


Thank you very much for looking at this whoever you are !!

Edited by maxarturo
Reneer Grand Master

Reneer

Posted
Posted (edited)

You would want something like this (haven't checked to see if it will compile) put on your Actor:

Scriptname RenSpawnBoxLowHealth extends Actor

Objectreference Property YourContainer Auto

Event OnInit()
    Self.RegisterForSingleUpdate(1.0)
endEvent

Event OnUpdate()

    if (GetActorValuePercentage("Health") <= 0.5 || IsDead() == true)
        YourContainer.Enable()
    else
        Self.RegisterForSingleUpdate(1.0)
    endif
    
endEvent
Edit: Fixed a numerical mistake as noted by ReDragon2013. Edited by Reneer
maxarturo Grand Master

maxarturo

Posted
  • Author
Posted
  On 3/27/2019 at 9:19 PM, Reneer said:

 

You would want something like this (haven't checked to see if it will compile) put on your Actor:

Scriptname RenSpawnBoxLowHealth extends Actor

Objectreference Property YourContainer Auto

Event OnInit()
    Self.RegisterForSingleUpdate(1.0)
endEvent

Event OnUpdate()

    if (GetActorValuePercentage("Health") <= 50 || IsDead() == true)
        YourContainer.Enable()
    else
        Self.RegisterForSingleUpdate(1.0)
    endif
    
endEvent

Thanks Reneer.

"GetActorValuePercentage" is nowhere in creationkit.com. my primary source of script information. Or, i completely missed it...

TobiaszPL

TobiaszPL

Posted
Posted

O_o but Maxarturo...

 

"GetActorValuePercentage" is useless...

 

cant u just multiply ActorValue by value less than 1 ?

 

for example

Health * 0.30 = 30% of Health Value

Health * 0.75 = 75% of Health Value

Health * 1.30 = 130 % of Health Value

 

 

also i no trust threads and registers and i try to use them not very much << sry 4 my english trying to find words but can't xD

 

while ( ... )

 

Utility.wait( ... )

 

endwhile

 

 

and one loop w8ing for Unit to have 50% or less hp :x

well you can add OnActivate to Actor and idk what you think about this but it was working for me many times :x

 

simple TriggerBox to activate Actor xD even if he is active :D

well i was activating Sweetrol many times even if it was completly static object :P

 

 

 

 

using register for single update isn't great idea for me... or too many threads

once i was writing game in C++ and i write class to support images and i forgot to delete temp array

 

and i got some problems with this and "WTF is wrong xD" after 5h of looking where is bad line of code

i discover that i just forgot delete Image temp array after loading Bitmap :P

 

 

 

Value in script can be stored even after save / load

and what if player save and load while for example script was registering new update and still had one?

 

idk where but once i read that register for single update each 1 second is very bad idea

 

but ok its just my opinion and how i would do it :x...

maxarturo Grand Master

maxarturo

Posted
  • Author
Posted
Hi Toby.

As i said i have some work to do with the cell before the creation of this Script & the finalization of the "Primary" script, i'm in a research script situation right now.

So i'm open for every & everyone's suggestion.

Reneer Grand Master

Reneer

Posted
Posted (edited)
  On 3/27/2019 at 9:49 PM, TobiaszPL said:

o_O but Maxarturo...

 

"GetActorValuePercentage" is useless...

 

cant u just multiply ActorValue by value less than 1 ?

 

for example

Health * 0.30 = 30% of Health Value

Health * 0.75 = 75% of Health Value

Health * 1.30 = 130 % of Health Value

 

 

also i no trust threads and registers and i try to use them not very much << sry 4 my english trying to find words but can't xD

 

while ( ... )

 

Utility.wait( ... )

 

endwhile

 

 

and one loop w8ing for Unit to have 50% or less hp :x

well you can add OnActivate to Actor and idk what you think about this but it was working for me many times :x

 

simple TriggerBox to activate Actor xD even if he is active :D

well i was activating Sweetrol many times even if it was completly static object :tongue:

 

 

 

 

using register for single update isn't great idea for me... or too many threads

once i was writing game in C++ and i write class to support images and i forgot to delete temp array

 

and i got some problems with this and "WTF is wrong xD" after 5h of looking where is bad line of code

i discover that i just forgot delete Image temp array after loading Bitmap :tongue:

 

 

 

Value in script can be stored even after save / load

and what if player save and load while for example script was registering new update and still had one?

 

idk where but once i read that register for single update each 1 second is very bad idea

 

but ok its just my opinion and how i would do it :x...

Several important things:

 

1. RegisterForSingleUpdate is the preferred method of polling versus RegisterForUpdate. See here for more information. Using RegisterForSingleUpdate(1.0) will not have any adverse consequences here and won't cause any save / load issues, unlike RegisterForUpdate.

2. Using a while loop as you suggested is a bad idea because it will essentially lock up the script until the actor's health is below 50% and nothing else could be done until that while loop exits. And if that actor spawns but their health doesn't drop below 50% the script will be locked forever.

3. GetActorValuePercentage isn't "useless" it is simply a convenience function.

Edited by Reneer
TobiaszPL

TobiaszPL

Posted
Posted

1. pff.. ok xD

 

2. you can always stop loop when player leave cell

 

3. for what you need function if you can use math ?

 

its like using

int addthisformepls( int a , int b ) { return a + b ; }

instead of using a+b lel...

 

 

but ok, its not my script but if it would be my i will never use threads for this :P

cause its like little thread :x...

ReDragon2013 Proficient

ReDragon2013

Posted
Posted (edited)

Dear Reneer,

 

you posted:

if (GetActorValuePercentage("Health") <= 50 || IsDead() == true)

I believe it should be as follow

if (GetActorValuePercentage("Health") <= 0.5 || IsDead() == true)

you give answer:

3. GetActorValuePercentage isn't "useless" it is simply a convenience function.

GetActorValuePercentage is native function, GetAVPercentage is the convenience function

 

I have rewritten your sample code as follow:

EnableTrigger50pActorScript

  Reveal hidden contents

 

 

EnableTrigger50pScript

  Reveal hidden contents

 

Edited by ReDragon2013
 Share
Go to topic listing

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...