increasing the crime bounty for a specific crime

[ThalmorJusticiar7th]

Quote

skse version

well there seems to be an issue that CK has with compiling SKSE related scripts,

i get an error on RegisterForMenu (and UnRegisterForMenu), saying the function does not exist.

i tried to compile both in CK and in notepad++ and the result was the same, here's an image of the issue:

Edited March 28 by ThalmorJusticiar7th
forgot to link the quote

[dylbill]

Most likely your source scripts aren’t in the right folder. In SE they changed the source folder to data/source/scripts while in le it was data/scripts/source. I just always make sure all the source .psc scripts are in both folders

[ThalmorJusticiar7th]

2 hours ago, dylbill said:

Most likely your source scripts aren’t in the right folder. In SE they changed the source folder to data/source/scripts while in le it was data/scripts/source. I just always make sure all the source .psc scripts are in both folders

so im doing it on SE. and its source/scripts in here. not to mention, somebody who is using SSE, would not want to do this just to get this piece of the mod working, they just want to plug and play.

 

so is there a way to just make it work as is with the location of scripts in SSE ? or do you need them in there just for compiling the mod, and the users do not have to do anything ?

[dylbill]

The user doesn't need the source files at all, they only need the .pex files in data/scripts. 

In your CreationKitCustom.ini, you can add this: 

[Papyrus]
sScriptSourceFolder = ".\Data\Scripts\Source"

But you will still need to copy the files from Data\Source\Scripts to there cause that's where the creation kit will have unzipped the source files to, 
and then re-install skse after to overwrite the .psc files. I just always make sure all source .psc files are in both folders so I don't have to worry about it.

 

[xkkmEl]

6 hours ago, dylbill said:

Most likely your source scripts aren’t in the right folder. In SE they changed the source folder to data/source/scripts while in le it was data/scripts/source. I just always make sure all the source .psc scripts are in both folders

I bet he tried putting this in a ReferenceAlias script, the "RegisterForMenu" call.

[dylbill]

34 minutes ago, xkkmEl said:

I bet he tried putting this in a ReferenceAlias script, the "RegisterForMenu" call.

RegisterForMenu should still work on a referenceAlias script.

[ThalmorJusticiar7th]

41 minutes ago, xkkmEl said:

I bet he tried putting this in a ReferenceAlias script, the "RegisterForMenu" call.

Edited March 28 by ThalmorJusticiar7th

[ThalmorJusticiar7th]

1 hour ago, dylbill said:

The user doesn't need the source files at all, they only need the .pex files in data/scripts. 

got it thanks, i'll just put the .psc files in the script/source folder as well then. i never understand why they did this in SSE in the first place.

[ThalmorJusticiar7th]

i don't know what the issue is, but i copied all the ".psc" files from "source/scripts" into "scripts/source" and then reinstalled SKSE (2.00.20 for 1.5.97 Skyrim),

then compiling again, same result:

 

Edit: nvm, i'll just reinstall CK, on a fresh skyrim install, and install SKSE on top, dropping all the .psc files in script/source and try again. thanks for the help.

Edited March 28 by ThalmorJusticiar7th

[ThalmorJusticiar7th]

So eversince the last post, i have been able to fix the issue with the Lockpickmenu not being recognized by CK, by reinstalling SKSE and putting its source/scripts in the right location for SSE (SKSE's .psc files should actually be in source/scripts in SSE).

 

then i went and tried this script in the game after compiling it. nothing happens. after closing the lock pick menu, the ".SetCrimeGold" does not fire off.

 

i then added messageboxes to all the Ifs in the script to see which event is not firing:

Faction Property CrimeFactionWinterhold  Auto

int crimeGold

Event OnActivate(ObjectReference akActionRef)
    
    If akActionRef == Game.GetPlayer()
        
        If UI.IsMenuOpen("Lockpicking Menu")
            
            crimeGold = CrimeFactionWinterhold.GetCrimeGold()
            
            RegisterForMenu("Lockpicking Menu")
        
            Debug.messagebox("lockpick menu opened")
        EndIf
        
    EndIf
    
EndEvent 


Event OnMenuClose(string menuName)
    
    If menuName == "Lockpicking Menu"
        
        UnRegisterForMenu("Lockpicking Menu")
        
        Utility.Wait(1)
        
        Debug.messagebox("lockpick menu closed")
        
        int newCrimeGold = CrimeFactionWinterhold.GetCrimeGold()
        
        int diff = newCrimeGold - crimeGold
        
        If diff > 0 ;player was likely caught
            
            CrimeFactionWinterhold.SetCrimeGold(newCrimeGold + 750) ;add 750 to crime gold

            Debug.messagebox("New Crime Bounty Set")
        EndIf
        
    EndIf
    
EndEvent

 

the Lockpickmenu Open/close functions work as intented:

 

so the only "If" that is not working is the:

        If diff > 0 ;player was likely caught
            
            CrimeFactionWinterhold.SetCrimeGold(newCrimeGold + 750) ;add 750 to crime gold


        EndIf

 

so my conclusion is that the diff property, is not firing due to its flawed logic (int diff = newCrimeGold - crimeGold), therefore the: "If diff > 0" never happens and subsequently, ".SetCrimeGold" will not be set either.

if the crime bounty has not already increased, then therefore, "diff > 0" does not happen in the first place.

 

let me know what can be done here, and whether i might've gotten the logic wrong, @dylbill. thank you.