Question regarding "GetEquipped"

[Crystalking52]

Greetings, I've recently begun modding Skyrim and I'm still a little shaky on the new scripting language. I was just curious how I would now ask the game what the player has equipped in the way of 'armor'? The script I am working on runs after completion of the quest "Fit for a Jarl" and is supposed to exchange the player's "Radiant Raiment Fine Clothes" for the standard version.

;BEGIN FRAGMENT CODE - Do not edit anything between this and the end comment
;NEXT FRAGMENT INDEX 1
Scriptname TIF__000C7B03 Extends TopicInfo Hidden

;BEGIN FRAGMENT Fragment_0
Function Fragment_0(ObjectReference akSpeakerRef)
Actor akSpeaker = akSpeakerRef as Actor
;BEGIN CODE
Game.GetPlayer().AddItem(LvlQuestReward01Small)
If Game.GetPlayer().GetEquipped(ClothesRadiantRaimentFineClothes01)
	Game.GetPlayer().RemoveItem (ClothesRadiantRaimentFineClothes01, abSilent = true)
	Game.GetPlayer().AddItem(ClothesFineClothes01, abSilent = true)
	Game.GetPlayer().EquipItem(ClothesFineClothes01)
Else
	Game.GetPlayer().RemoveItem(ClothesRadiantRaimentFineClothes01, abSilent = true)
	Game.GetPlayer().AddItem(ClothesFineClothes01, abSilent = true)
EndIf
GetOwningQuest().Setstage(30)
;END CODE
EndFunction
;END FRAGMENT

;END FRAGMENT CODE - Do not edit anything between this and the begin comment

LeveledItem Property LvlQuestReward01Small  Auto  

Armor Property ClothesRadiantRaimentFineClothes01 Auto  

Armor Property ClothesFineClothes01 Auto  

MiscObject Property Gold001  Auto  

However, the GetEquipped condition is apparently incorrect. What would be the correct way to state this then?

[IsharaMeradin]

GetEquipped is a condition function usable in the various condition boxes found on several forms (quest stages, perks, effects, etc...)

 

In your case you want IsEquipped instead

 

 

;BEGIN FRAGMENT Fragment_0
Function Fragment_0(ObjectReference akSpeakerRef)
Actor akSpeaker = akSpeakerRef as Actor
;BEGIN CODE
Game.GetPlayer().AddItem(LvlQuestReward01Small)
If Game.GetPlayer().IsEquipped(ClothesRadiantRaimentFineClothes01)
	Game.GetPlayer().RemoveItem (ClothesRadiantRaimentFineClothes01, abSilent = true)
	Game.GetPlayer().AddItem(ClothesFineClothes01, abSilent = true)
	Game.GetPlayer().EquipItem(ClothesFineClothes01)
Else
	Game.GetPlayer().RemoveItem(ClothesRadiantRaimentFineClothes01, abSilent = true)
	Game.GetPlayer().AddItem(ClothesFineClothes01, abSilent = true)
EndIf
GetOwningQuest().Setstage(30)
;END CODE
EndFunction
;END FRAGMENT

 

 

May I suggest that you add the new item and force equip it before removing the already equipped item. If you do not, you'll get a flash of underwear/nudity.

 

This variant adds the new item, equips it only if the specified item is equipped, then removes the specified item. Since you were adding the one and removing the other in all cases, there was no point in duplicating that code unnecessarily.

;BEGIN FRAGMENT Fragment_0
Function Fragment_0(ObjectReference akSpeakerRef)
Actor akSpeaker = akSpeakerRef as Actor
;BEGIN CODE
Game.GetPlayer().AddItem(LvlQuestReward01Small)
Game.GetPlayer().AddItem(ClothesFineClothes01, abSilent = true)
If Game.GetPlayer().IsEquipped(ClothesRadiantRaimentFineClothes01)
	Game.GetPlayer().EquipItem(ClothesFineClothes01)
EndIf
Game.GetPlayer().RemoveItem(ClothesRadiantRaimentFineClothes01, abSilent = true)
GetOwningQuest().Setstage(30)
;END CODE
EndFunction
;END FRAGMENT 

 

 

[Crystalking52]

You have been very helpful sir! I shall make your suggested change as well since I hadn't though about the brief flash. Thank you very much!

Edited July 24, 2014 by Crystalking52

[Crystalking52]

Terribly sorry to bump this, but I have just gotten around to testing the script in-game and it did not work. I had the .pex file in the scripts folder and named exactly the same as the default script but the game just used the vanilla script instead. Was it because I moved the .psc file out of the source folder or do I need to edit the dialogue topic in some way too?

[IsharaMeradin]

At what point did you test the script out? If it was mid-quest, that was the problem. Try on a new game or a save that has never had that quest active at all.

 

When a quest starts, all script fragments associated with it are loaded up and ran at the appropriate moments. So if you changed the fragment and tested after the quest had already been started, the pre-loaded version of the script would be used instead of the modified version.

[Crystalking52]

At what point did you test the script out? If it was mid-quest, that was the problem. Try on a new game or a save that has never had that quest active at all.

 

When a quest starts, all script fragments associated with it are loaded up and ran at the appropriate moments. So if you changed the fragment and tested after the quest had already been started, the pre-loaded version of the script would be used instead of the modified version.

I had inserted the script in before starting the quest but I've figured out what I did wrong. Turns out, I also needed to define the objects in the quest itself and not just from the script. Thanks for all of your help again sir.