SetAV on ActorBase

[Mattiewagg]

Is this possible? If so... How so?

 

I have an ActorBase array, and I need to call SetActorValue on each one. How would it look? (Current non-working-code):

Int mIndex = MarkarthHorses.Length

While mIndex

	MarkarthHorses[mIndex].SetActorValue("Stamina", (MarkarthHorses[mIndex].GetActorValue("Stamina") + 75))

EndWhile

[mastabenja]

int mIndex =1

Event OnEffectStart(Actor  MArkarthHorses, Actor  MArkarthHorsesActor)

While mIndex
float currentValue = MArkarthHorses.GetActorValue("Stamina")
int _currentValue = MArkarthHorses.GetActorValue("Stamina") as int

int newValue = _currentValue + 75
    MarkarthHorses.SetActorValue("Stamina", newValue)

EndWhile

EndEvent

I didnt test it ingame since i dont have all actors set up and dont have your array etc. and the while is obviously just a permanent loop (DONT USE THAT INGAME PLEASE). Compiles just fine for me in CK. Logic should be right i think

 

this should be working as well and its close to your line

Int mIndex = MarkarthHorses.Length

While mIndex

    MarkarthHorses[mIndex].SetActorValue("Stamina", ((MarkarthHorses[mIndex].GetActorValue("Stamina") as int) + 75))

EndWhile

so i thnk your basic problem is that .GetActorValue and similar function return _floats_ floats can not be used as Int (numeric values). You have to use http://www.creationkit.com/Cast_Reference#Cast_to_Int "as Int". Or if you are fiddeling with globals you can use myGlobal.GetValueInt() (its an easy wai to get the game time for example Int _gameHour = GameHour.GetValueInt())

 

also notice:

GetActorValue returns the CURRENT value of in this case stamina while SetActorValue set the base value. This eans if your targeted horse currently is drained of stamina (for what ever reason) you might get unintended value with this. Use GetBaseActorValue instead if you want (i guess thats waht you want to do). There is also ModActorValue (or simillar) that sets the base and the current value at the same time afaik (so your set base get "filled up")

 

let me know if it works. cant setup a simple mod to test right now. Im not on my desk

 

Edit: on second thought: your array may just suck and it has nothing to do with all the aboth XD

Edited August 25, 2014 by mastabenja

[Mattiewagg]

int mIndex =1

Event OnEffectStart(Actor  MArkarthHorses, Actor  MArkarthHorsesActor)

While mIndex
float currentValue = MArkarthHorses.GetActorValue("Stamina")
int _currentValue = MArkarthHorses.GetActorValue("Stamina") as int

int newValue = _currentValue + 75
    MarkarthHorses.SetActorValue("Stamina", newValue)

EndWhile

EndEvent

I didnt test it ingame since i dont have all actors set up and dont have your array etc. and the while is obviously just a permanent loop (DONT USE THAT INGAME PLEASE). Compiles just fine for me in CK. Logic should be right i think

 

this should be working as well and its close to your line

Int mIndex = MarkarthHorses.Length

While mIndex

    MarkarthHorses[mIndex].SetActorValue("Stamina", ((MarkarthHorses[mIndex].GetActorValue("Stamina") as int) + 75))

EndWhile

so i thnk your basic problem is that .GetActorValue and similar function return _floats_ floats can not be used as Int (numeric values). You have to use http://www.creationkit.com/Cast_Reference#Cast_to_Int "as Int". Or if you are fiddeling with globals you can use myGlobal.GetValueInt() (its an easy wai to get the game time for example Int _gameHour = GameHour.GetValueInt())

 

also notice:

GetActorValue returns the CURRENT value of in this case stamina while SetActorValue set the base value. This eans if your targeted horse currently is drained of stamina (for what ever reason) you might get unintended value with this. Use GetBaseActorValue instead if you want (i guess thats waht you want to do).

 

let me know if it works. cant setup a simple mod to test right now. Im not on my desk

 

Alright. Thanks. And I wouldn't use that While, don't worry. I was just worried that because the ActorValue functions are on the Actor Script, they wouldn't work on Actor bases.

[mastabenja]

hm dunno try and error like allways^^

[Mattiewagg]

hm dunno try and error like allways^^

Well I'm having an error that SetActorValue doesn't exist as a function... Here's my script, though it's clearly not finished:

Scriptname UHBStatChange extends Quest  
{Changes horse stats when the mod is installed.
Governs all Unique Horse Breeds related changes.}
ActorBase[] Property WindhelmHorses  Auto  
{All Windhelm horses.}

ActorBase Property WhiterunHorse  Auto  
{Whiterun horse.}

ActorBase[] Property MarkarthHorses  Auto  
{All Markarth horses.}

ActorBase[] Property RiftenHorses  Auto  
{All Riften horses.}

ActorBase[] Property SolitudeHorses  Auto  
{All Solitude horses.}

Function ChangeHorseStats(String WhichHorses)

	If WhichHorses == "MarkarthHorses"

		;change stats for MarkarthHorses
		Int mIndex = MarkarthHorses.Length

		While mIndex

			MarkarthHorses[mIndex].SetActorValue("Stamina", (MarkarthHorses[mIndex].GetActorValue("Stamina") + 75.0))
			mIndex -= 1

		EndWhile

	ElseIf WhichHorses == "WhiterunHorse"

		;change stats for WhiterunHorse

	ElseIf WhichHorses == "RiftenHorses"

		;change stats for RiftenHorses
		Int rIndex = RiftenHorses.Length

	ElseIf WhichHorses == "SolitudeHorses"

		;change stats for SolitudeHorses
		Int sIndex = SolitudeHorses.Length

	ElseIf WhichHorses == "WindhelmHorses"

		;change stats for WindhelmHorses
		Int wIndex = WindhelmHorses.Length

	EndIf

EndFunction

Compiler errors:

Starting 1 compile threads for 1 files...
Compiling "UHBStatChange"...
C:\Program Files (x86)\Steam\steamapps\common\skyrim\Data\Scripts\Source\UHBStatChange.psc(28,26): SetActorValue is not a function or does not exist
No output generated for UHBStatChange.psc, compilation failed.

Batch compile of 1 files finished. 0 succeeded, 1 failed.
Failed on UHBStatChange.psc
[Finished in 1.0s with exit code -1]

[mastabenja]

MarkarthHorses[mIndex].SetActorValue("Stamina", ((MarkarthHorses[mIndex].GetActorValue("Stamina") as int) + 75.0))

if you did this allready (use "as int"!!!) then you should try and print out the actor value in game by using something like this in some modified script that compiles and has your array working (make it work^^)

 

int _whatEver = MarkarthHorses[mIndex].GetActorValue("Stamina") as int
Debug.Notification("stamina value: " + _whatEver)

 

I didnt work with arrays in papyrus yet but that looks strange. Are you sure that array is filled correctly? Well if your array isnt working i cant help you sorry :/

Edited August 25, 2014 by mastabenja

[Mattiewagg]

MarkarthHorses[mIndex].SetActorValue("Stamina", ((MarkarthHorses[mIndex].GetActorValue("Stamina") as int) + 75.0))

if you did this allready (use "as int"!!!) then you should try and print out the actor value in game by using something like this in some modified script that compiles and has your array working (make it work^^)

int _whatEver = MarkarthHorses[mIndex].GetActorValue("Stamina") as int
Debug.Notification("stamina value: " + _whatEver)

I didnt work with arrays in papyrus yet but that looks strange. Are you sure that array is filled correctly? Well if your array isnt working i cant help you sorry :/

 

I tried it with a normal actor property as well, and that didn't work either.

 

EDIT: It works now, probably just a case of not working on actor bases... That's bad.

Edited August 25, 2014 by Matthiaswagg

[mastabenja]

ok i have no f***ing idea of how to do it the right way... The ActorBase functions are so limited even with skse. You might have to look in another direction to do this.

Check Convenient horses for its option to set the stamina bonus of horses and use a similar method? But im not sure if this will only affect the horses owned by the player.

so many people doing horse races right now oO

 

Edit: Your Whitrun horses dont have array brackets... probably not important

 

ActorBase[] Property MarkarthHorses Auto

ActorBase Property WhiterunHorse Auto

Edited August 25, 2014 by mastabenja

[mastabenja]

ok so. As you cant set the value of an ActorBase you need to work around it. CH does this by adding a quest ("CH") with the "Horse" alias that runs a script (chhorsealiasscript.psc) that then manipulates the stamina value acording to a global set in the MCM of convenient horses.

If im right you should be able to add a quest to the ActorBase for horses (by using the horse faction maybe) that does a similar stamina modification. If done right this would affect all horses i think. Need to figre out how exactly you can split them up in breeds

 

thats my last idea^^

Edited August 25, 2014 by mastabenja

[Mattiewagg]

ok so. As you cant set the value of an ActorBase you need to work around it. CH does this by adding a quest ("CH") with the "Horse" alias that runs a script (chhorsealiasscript.psc) that then manipulates the stamina value acording to a global set in the MCM of convenient horses.

If im right you should be able to add a quest to the ActorBase for horses (by using the horse faction maybe) that does a similar stamina modification. If done right this would affect all horses i think. Need to figre out how exactly you can split them up in breeds

 

thats my last idea^^

Thanks :smile:.