Need someone to check a short script and quest info, to make sure I don't break stuff.

[Aceofrogues]

Before releasing this small mod, I want to be sure that I don't break peoples saves. The mod consists of a script and a quest.

A screenshot of the quest attached below.
And the script

scn FNCCompanionAmmoScript

Begin Gamemode

if ( PBJeniferHaleRef.GetItemCount AmmoCompanion <= 300 )

PBJeniferHaleRef.AddItem AmmoCompanion 200 1

endif

if ( PBBenKurtzRef.GetItemCount AmmoCompanion <= 300 )

PBBenKurtzRef.AddItem AmmoCompanion 200 1

endif

if ( PBKiraMannRef.GetItemCount AmmoCompanion <= 300 )

PBKiraMannRef.AddItem AmmoCompanion 200 1

endif

if ( PBJamieCampbellRef.GetItemCount AmmoCompanion <= 300 )

PBJamieCampbellRef.AddItem AmmoCompanion 200 1

endif

if ( PBEricCampbellRef.GetItemCount AmmoCompanion <= 300 )

PBEricCampbellRef.AddItem AmmoCompanion 200 1

endif

if ( PBrazilAlphaDroidREF.GetItemCount AmmoCompanion <= 300 )

PBrazilAlphaDroidREF.AddItem AmmoCompanion 200 1

endif

if ( PBB6RKref.GetItemCount AmmoCompanion <= 300 )

PBB6RKref.AddItem AmmoCompanion 200 1

endif

end

 

----------------------------------------------------

 

I've played with it for a couple of hours and the amount of ammo they have haven't exploded.

[dubiousintent]

The basics don't appear to do anything incorrectly. (I am presuming that you are already taking into account what "type" of ammo (e.g. caliber, functional characteristic such as "incendiary") is currently being used.) You will get a slight bit of more efficiency by making your test "< 301". "<=" is a "compound" condition that has to test for both LT and EQ.

 

FYI: However, I wonder if you are aware that the mod "JIP Companions Command and Control (JIP CC&C)" allows you to give your companions "infinite ammo" already? Seems you are re-inventing the wheel.

 

-Dubious-

[Aceofrogues]

Thank you for taking the time to answer. I was not aware that JIP CC&C also did that, but it does a lot more. So for people only wanting infinite ammo this does that :)