Jump to content

[LE] Help to make this script to compile successfully

qwertypol012

By qwertypol012
in Creation Kit and Modders

 Share

Recommended Posts

qwertypol012 Collaborator

qwertypol012

Posted
Posted (edited)

I have a script which extends ActiveMagicEffect. The name is "qlRevertFormScript". This script is attached to a MGEF, which then casted from a spell and works to the player (ie. self casted).

 

This script calls a function from another script, ie. "qlTransformScript". qlTransformScript is attached to 2 other MGEFs and both of them also self casted (casted to the player). The function to call from qlTransformScript is RevertForm(Actor player). I want to call this function from qlRevertFormScript. I've tried to google and followed some guidances on how to call a script's function from another script and if there are more than 1 instance using the same script, but still no luck. The script i made just won't compile. So i want to ask help for anyone here on how to make it work.

 

Here are the relevant variables and infos for qlRevertFormScript:

 

BerserkArmorBeastT (1st MGEF which qlTransformScript is attached to)

BerserkArmorBeastTDanger (2nd MGEF which qlTransformScript is attached to)

qlTransformScript (the script which contains the function i want to call from qlRevertFormScript)

RevertForm(Actor player) (the function to be called)

 

What i want to do is check if the player has either BerserkArmorBeastT or BerserkArmorBeastTDanger, and if he/she has then call the function. (pretty simple right? but i failed miserably :sweat: )

I'm using event OnEffectStart(Actor akTarget, Actor akCaster) which the function is called inside it.

 

If there's any additional infos needed, just tell me then i'll fill it. Thanks in advance :smile:

Edited by qwertypol012
ReDragon2013 Proficient

ReDragon2013

Posted
Posted (edited)

Remember you posted the scripts https://forums.nexusmods.com/index.php?/topic/7301906-how-to-properly-script-a-custom-conditional-system-which-will-be-used-by-a-quest-script/

 

The way you go is impossible! You cannot call to functions in "ActiveMagicEffectScript" scripts. Store functions in a quest script to call them with cross scripting from AES scripts or any other type.

 

qlBerserk_TransformScript

  Reveal hidden contents

 

 

qlBerserk_QuestScript

  Reveal hidden contents

 

Edited by ReDragon2013
qwertypol012 Collaborator

qwertypol012

Posted
  • Author
Posted (edited)

Cheers man! You're truly a savior, hahaha :laugh:

 

I suppose it's actually better if i posted this question under my original thead: https://forums.nexusmods.com/index.php?/topic/7301906-how-to-properly-script-a-custom-conditional-system-which-will-be-used-by-a-quest-script/

It's just that this is a special case since it's the only script failed to compile among my other scripts.

 

So, now i understand that it's impossible to call functions from ActiveMagicEffect type scripts. I did find a question regarding calling functions from other scripts (solved by Chesko and IsharaMeradin), but it was a script related with ObjectReference or RefAlias (if i'm not mistaken). I thought that it would also work for ActiveMagicEffect.

 

Okay, now i guess i need to edit my quest script again and recompile it. Thanks for the help! :thumbsup:

Edited by qwertypol012
Evangela Mentor

Evangela

Posted
Posted

It's not possible because ActiveMagicEffect scripts don't persist, they are the worse route to go for any sort of data holding/querying. Quests are extremely good for this.

qwertypol012 Collaborator

qwertypol012

Posted
  • Author
Posted (edited)

@Rasikko

I see. That makes sense. Thanks for the explanation. I assume that it works for ObjectRef, Form, and Actor type scripts, right? And the exact instance which the script is attached to needs to be referenced properly. Is this correct?

 

 

@ReDragon2013

I still fail to understand this function from your edited quest script:

 

  Reveal hidden contents

 

I have several questions regarding this.

 

1. As far as i can understand, the line "(fm as Armor)" identifies fm as Armor as a replacement for GetWornForm, correct? So, something like this work even if we don't use GetWornForm??

When "Int i" is filled (or identified) with slotmask value (eg. 0x00000008, etc), how does "fm" take its value (or identified itself) from that "Int i"?? I still fail to understand relation between them.

 

2. Next, what about this part?

 

  Reveal hidden contents

 

Does it really really do anything? The ELSE is not even filled with anything. I'm not sure what this part does and why does it exist?

 

3. Next, i noticed that the function calling it (ie. MakeForm) identifies above function like this: myF_AE(player, 0x00000008).

This is just i'm asking. What's the function of "Int i" in myF_AE(Actor player, Int i, Bool bAdd = TRUE)? Is it supposed to be identified with "form fm"?

Also, why this function has a Bool (bAdd = TRUE)? I noticed that this is not a Bool Function, so why does it contain a Bool?

Edit: About this part, i think i've figured it out. This Bool is used when the function is called by RevertForm. But i still couldn't understand the relation between "Int i" and "fm".

 

4. Next, there's this line in the end of the function:

player.EquipItem(fm, False, TRUE)

What does it for? I couldn't remember a line like this in the previous version of the script (inside MakeForm and RevertForm functions).

Edit: Just like above, i figured it out that this line will run when the Bool is False.

Edited by qwertypol012
ReDragon2013 Proficient

ReDragon2013

Posted
Posted (edited)

I edited my last posting. I removed the line with "GetWornForm()", because I didn't installed SKSE! I forgot to remove the semicolons.

 

from MakeForm()

    myF_AE(player, 0x00000008)                    ; myF_AE(player, 0x00000008, TRUE)
;;;    fm = player.GetWornForm(0x00000008)        ; Gauntlets
;;;    IF (fm as Armor)
;;;        PlayerEquipmentBrsk.AddItem(fm, absilent=true)
;;;        PlayerEquipmentBrsk.EquipItem(fm, true, true)
;;;;          Debug.MessageBox(Gauntlets)
;;;    ENDIF

from RevertForm()

    myF_AE(player, 0x00000008, False)
;;;    fm = PlayerEquipmentBrsk.GetWornForm(0x00000008)    ; Gaunlets
;;;    IF (fm as Armor)
;;;        player.EquipItem(fm, false, true)
;;;    ENDIF

you wrote: "4. Next, there's this line in the end of the function"

"i" is function parameter which is filled with a hexnumber like 0x00000008.

;-----------------------------------------------------
FUNCTION myF_AE(Actor player, Int i, Bool bAdd = TRUE)  ; internal helper (edited 2019/02/11)
;-----------------------------------------------------
    form fm

    IF ( bAdd )
        fm = player.GetWornForm(i)                    ; called from MakeForm()
    ELSE
        fm = PlayerEquipmentBrsk.GetWornForm(i)       ; called from RevertForm()
    ENDIF

IF (fm as Armor)
ELSE
    RETURN    ; - STOP -    nothing worn at this slot
ENDIF
;---------------------
IF ( bAdd )
    PlayerEquipmentBrsk.AddItem(fm, absilent=TRUE)       ; (A)dd
    PlayerEquipmentBrsk.EquipItem(fm, TRUE, TRUE)        ; (E)quip
ELSE
    player.EquipItem(fm, False, TRUE)                    ; equip only
ENDIF
ENDFUNCTION
Edited by ReDragon2013
qwertypol012 Collaborator

qwertypol012

Posted
  • Author
Posted

Now that makes sense! :laugh:

 

I was super confused with the first version of your script, but after you edited it things become clear :teehee:

 

Alright, thanks for the help. Let me work on my parts, and hopefully no more problems :smile:

 Share
Go to topic listing

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...