[LE] Some scripting Tips? Making a auto sell stuff mod...

[Pellape]

Ahh. Okay. Very nice. Well something has changed and I cannot say if I was wrong or not really as I do think I did empty my whole inventory when I checked my total weight. The thing is, it has sorted it self out. I will take one more look of my total weight but last time I did check it in game, it was 387 :D

1. So what have I done, well I added that line to the SKSE64.ini
2. I did looked through every item, found a stack of 712 Fire wood, that is 1400 in weight.... :D

It can be so that my collecting of Fire Wood is the cause of me imagine am inventory bloat really. Why do I carry so much Fire Wood in the first place?

 

Fire Wood was rare 2011 and I also remember or recall it was rare when I played the game the second time 2020. So I found a mod that adds stacks of Fire Wood everywhere, and as I am a bloody Hamster, junk collector or what ever, I cannot resist picking every stack I see. I have maybe 2-3000 Fire Wood right now. Okay, we can add Fire Wood to our inventory when ever we feel like it and whatever, but that is not immersive and not how I wanna play the game. I can turn on GOD MODE, and play Sheogorath. Still that is not how I wanna do things. I do cheat, as I mod stuff, but I do try to make it immersive but also practical. My sell all items is not immersive but it makes tings easier. I do have a limit of what is actually fun... :wink:

 

I use the Fire Wood as I play FrostFall, a hunter, Hunterborn and Camping. And I love it. It adds so much more to the game, small things but still it gets a bit OP when i also use Skrimshaw crafting, making very powerful and expensive amulets. I do not mind honestly. Gold is never an issue in TES, well except TES 2 that is as I do not recall I ever cheated in that game :D Not do I know how honestly. Modding it is so odd as it is possible with the Unity Engine, but the mods are all very random, and making a quest in Daggerfall is extremely odd and it has no editor like we have but still it is cool. Everything is Object Oriented and random and stuff can happen anywhere with help of Conditions. Lets say you do a TG quest, an item is added to a house and that house is random and you have to ask around in the town or anywhere, where to find the house and it can be a pain in the rear, as you have to be good in 2 skills. Nobilty and Commoner or whatever it is called now again, which became Speechcraft in TES 3. The Nobility will always treat you like s***, but you can actually get popular at least among the Commoners and they will help you, more than the Mobility ever will. Well Never mind, this is not about Daggerfall. It is about my inventory. :D Still, it is cool, but it also gets boring after a while. :D

 

So no thought about my spells? I will most likely make it into a Alteration spell honestly. It makes more sense and at least, I can see what the script is doing at least if I make it the way I made the Spell in the Sell Stuff Mod. Its just, I really wanted it to be a summoning spell in the Conjuring School but does it really make sense? No it does not. We do Alter a Dwemer Engine in Tamriel, not summoning stuff From Oblivion, Sovnegarde or whatever, as that is what Conjuring is doing in my world. The word Summon, is calling. I do call the horses to me, do I not? Well Never Mind, I should not spend time on it really. But if you have any idea why that Summing Spell did fail, let me know but I honestly think it is the Targeting Spot but it could also be the short Casting Time or Duration, but still, I cannot see if the Script is running. It gives no message nor any text in the console. I could also just watch a video about how to do it as well, but I rather read your opinions honestly. Here I can at least ask the right questions. :D

Edited July 16, 2022 by Pellape

[IsharaMeradin]

I did do a few spells that were summoning based but I don't recall anything about them. Spells are not my strong suit. My mods tend to be script based.

You can take a look at my A Mage's Night Out mod (for 32 bit Skyrim) to see those spells if you want.

 

Hopefully someone else will be able to assist you with your spells.

[Pellape]

I managed to make the spells and I did post about it at my flat, but I cannot find the posts now, nor do i know where I did send them. :D i did upload 2 screenshots and that will do for now. The script it self is not that important right now. What is important is how I actually solved it. But lets make one thing clear and correct me if I am wrong of course. PROPERTY is not the same as Reference. Look at this screenshot and taste it for a couple of seconds. Look at the referencename and compare it to the PROPERTY name. they are not the same.

So the PROPERTY is the variable, the pointer to the reference, which is a PROPERTY holder for the Object data, like a bloody container with coordinates, ownership and some other useful Properties and maybe that is why it actually is named a PROPERTY? Still they are not the same and should be different. I did name the PROPERTY to pekOriginalHorseREF andf the referenceis actually named pekOriginalHorse02REF and ther reason i did figure this out was an accident. I renamed the Reference as I deleted the original pekOriginalHorseREF and renamed the reference to pekOriginalHorse02REF and pointed at the horse, and it struck me. YES!!! This is the way it should be done really. It worked. Look here:

I also did noticed that the XmarkerHeading is persistant as you see the p after the (), so (xxxxxxxx)p is a persitant ref and that is not needed for Creatures nor NPC as they are that by default, well if we set them essential I guess, but the original horse is essential. The Upgraded one is not, but i will set it later... No need to have it not to i guess. Well sh't the same...

The script write this at the console and see, the horse did pop up as well. :D

i will add 2 booleans at a questscript, as I refuse to cheat, making GLOBLAs, As I seen many do that, as they do not know better really. Wuest Scripts is a better variable holder honestly than using a GLOBAL. I did learn this in the C for Dummies or from the dourse I did go around 1990. GLOBALs is No NO. Weölö they will still take the same 8-bit in memeory anyway, if not more when the quest takes up space. It is the principle anyway. A quest variable holder is the proper way to go honestly never the less.



Those 2 Booleans will be used bu a follow package, with prio 1, well at top of the 2 packages. So the top package will be turned on and off by the bools at the quest script, well call it a GLOBAL if you want, as that is what it really is anyway. :D

Me, Inigo by foot and my critters, and that Dwarven horsie. The original so far. So next weeek I do the rest as now I have an Oblivion mod to make. One weel of oblivion modding YES!!!! :D Huuurray!!!! Back to the easy peasy world again. :D



But honestly. Why does the reference point at a script with that name? HOActorDeathRespawnScript? Well Skyrim is very very weird honestly. It makes no sense, not that name. I guess the horse has that script, as you build it from 5 parts. I only want it simple as I really do not care if others did made the quest or not. 2 Horses will be available at the Markath Stable anyway, ownership the player. The quest was actually fun to do, so I will of course suggest the player that use these summons, really consider doing the quest anyway. n

Lets debate SE versus AE, I use SE v1.5.97 as I was adviced not to upgrade it to v1.6 or whatever, for FNIS but I dio not use FNIS, not yet at least. It seems that the AE users cannot use the mod. I did ask 666qwertz666 who recompiled it for AE, to assist. Lets see what he replies with :D
If he say: Bugger Off like all Nobilities in Daggerfall do to my char every day, I need someone else to do it. I could also make a separate AE installation but honestly, for 2 scripts, no way... :wink:

 

I really love the Dwemer stuff. Just look at the Morrowind Dwemer collection at my Manor in Suran:

 

 

 

Here is my Endorced Dwemer Coffee machine I made in Blende 2 years ago:

 

It makes the strongest poison I ever seen in game... :wink:

 

 

Making the coffee can be a bit tricky so I made a video that explains how to mix the blends:

 

Edited July 16, 2022 by Pellape

[IsharaMeradin]

Properties are initially empty. They need to have the data assigned to them. This can be achieved in several ways.

 

Assume the following is within a script

ObjectReference Property myContainerOfUberGear Auto

 

If the intended target reference happens to have been given an Editor ID that exactly matches, the auto-fill button can be used to automatically assign the reference to the property.

If the intended target reference has a different Editor ID name, there will be input boxes that appear on the right hand side of the Properties Window when the property is selected, these boxes can be used to assign the intended data / object. Depending upon the property type, there may be an option to select the target in the Render Window.

Finally, properties can also be assigned data / object within the script itself:

ObjectReference Property myContainerOfUberGear Auto

Event OnInit()
  Debug.Trace("Property myContainerOfUberGear should be NONE. Is it? -- "+myContainerOfUberGear)
  myContainerOfUberGear = (Game.GetFormFromFile(0x12345678,"MyMod.esp") as ObjectReference)
  Debug.Trace("Property myContainerOfUberGear should be [12345678]. Is it? -- "+myContainerOfUberGear)
EndEvent

Regarding Globals:

If you are referring to Global Variables, these have valid uses and can be preferable to holding variable data within a quest. Global variables are good for sharing the status of many things across multiple scripts, spells, perks, quests, etc. Refusing to use them when necessary will cause more work as you will have to cross link scripts way more often. Global variables are also modifiable via the console and make for a good backup to customization when SKSE is only needed for an MCM menu.

[Pellape]

I saw you did use this in the other examples you did show me. myContainerOfUberGear = (Game.GetFormFromFile(0x12345678,"MyMod.esp") as ObjectReference) and we also have similar functions in OBSE, to allow us to actually implement other modders work, without making it a requirement. This was not needed in Morrowind at all.

I know Globals are very easy to use. I might use them, I will not say I will not. As I did start as a Basic andlater became a C programmer and did learn how to optimize and also structure my code, they did claim that profesional Programmers avoid Globals as it is TABU and not good practice and should always be avoided. let me give you an example.

Lets say you become a Professional and you get membership in a Programmer team. You will be tasked to a number of functions. Then you must follow the following rules and this is from that book, C for Dummies if I recall right. It is 32 years ago after all.

• A program must have a clear start and also a clear end.
  • That means a Basic Programmer should never use GOTO as he will use GOSUB, to avoid nasty loops. We can even use Goto in C and in TES scripts. It is very very nasty...
  • A C programmer should make Separate Functions as much as possible with a clear and simple input and a single Return Value, so when the function is used, all variables in it will no longer exist.

• Using Globals will use extra memory when the variable is NOT used, therefor avoid it at all costs. never use it. There is never an Excuse to use a GLOBAL when you will be able to use Local Variables within your own Functions.
• I have debated this with Maskar, who made this nice Overhaul and he is the best Oblivion scripter I have ever met. We have a ongoing dialogue in PM often, debating stuff, trying to help each other and now he try my mod, and so far, I really think he likes it. https://www.nexusmods.com/oblivion/mods/42780 and he also made the most brilliant and best Leveling Mod there is for oblivion: https://www.nexusmods.com/oblivion/mods/49134

The thing is is how I got in contact with him in the first place? I got problems with his mod, as it includes crafting and as you know, crafting is not part of the Oblivion world. He use a lot of ideas from Ultima Online, which we both did play 20 years ago. He could not reproduce my issues and he did tell me that there is no bugs to be found. So I forced my self to learn his scripts, as I love his mod and I tell you, it is the nastiest scripts I have ever seen and they are extremely hard to follow. Why? He use those rules. I did not claim it get easy to follow the code. It is NOT. He use as small functions as possible and avoid Globals. So reading it, require us to cross open loads of files, until your head is spinning and I just get dizzy when i look in his script. Still, if I want to make them work, I must. They work. I have something that interups with MOO. Oblivion is also the most buggy game Bethesda ever made, fallout 76 not included as that was not Bethesda. They did layout that project.Honestly: To solve a bug, you must also need to be able to reproduce it.

So I knew when the problem occurred in one of his functions and I showed it to him exactly where as well. I told him that I have solved it with a GLOBAL variable as that was all I needed to make, a Global Reference. Than he replied, a bit annoying really. I could show you the reply too as it is saved but I quote him from memory.

-Never use Globals. It is not good Practise. If you must do this, use a Quest Variable.

A GLOBAL Must always be unique if used but that counts everything honestly in the game, except local Variables. A reference must be Unique, well at least within the same mod. In Morrowind, there where no separation between the mods. They could all call each others scripts, object and references crossed every single mod easy. In Oblivion Bethesda stopped this as they knew it will only cause problems. In Morrowind, all modders started to initiate every single thing they did create with their 3 first letters and in Skyrim, it seems that even 4 letters is used now. It was we that started this around 2002 to avoid conflicts. But is it really needed these days? No. Only for a GLOBAL Variable as each mod is separated from each others anyway. But it is still a good practise, as It sure makes it easier forme to find my own stuff. All i need to filter is Pek, nothing else :D

Qarl, was lazy, as he started all his stuff with q.
Pekka, a, well that is me, started all his stuff with Pek, and still do

Neil, started everything with 1NE if I recall right and this was nasty, as that really caused a lot of bugs and crashes and Oblivion functions will break if the Object or referens starts with a number. It is not good. I did learn that 2000 and I remade this mod, as Neil made me stuff for my big project 2004. Peek here: It is the most decorated Dungeon for Morrowind ever, I guess. Well it did take me 2 years to make. Was it fun to make? NOOO!!! it is fun to play. I will never do this again, Ever. :D It still has players and as I did mention, I do have a name that I want to have connected with Quality. The mod works for me, but causes issues for others, and that was not acceptable, not for me if i can avoidit. I did hear about these issues first 2017 as I left Morrowind 2006, a week after the release of this project as Oblivion came a week later. https://www.nexusmods.com/morrowind/mods/48774

This Narrator and Video maker, previewer really is Important for the Morrowind Community today as he brings it back to life. What he say in this video, as he do preview 2 of my mods, is not fun to hear. So in one Video, he lifts me to the skies and in the other he dizz the stuff completely, saying: Do not use this. Play it through, but uninstall it when you are done, even use a new save file you go back to after playing this. Is that really what I wanted to hear? I had to do something. A fan of my stuff, called OblivionAdicted solved it. He knew what the problem was. i did not know!!! I did remake it 2020 as I cannot use my old account, so I remade it and made a new upload. So lets peek at the video, listen what he say, and it is never fun to hear that you did not make a quality mod, when that was my goal. So when I remade, it, I used all new knowledge, from what I did learn from Qarl 2006 (R.I.P 2011). Qarl was our mentor and best friend of AlienSlof and toughed her to mod and brought her here as another example. AlienSlof is best known for her lovely horses I guess. :D

 

https://danaeplays.thenet.sk/modders-interview-alienslof/

Well this is not acceptable. Listen:

I am not a professional programmer. I do want to become a professional 3D artist though, as that is funnier than coding honestly. But I applied to the education but 412 applied and they only accept 32. I will upgrade my grades this autumn as I will get in, I must. I did include my stuff, it did not help. Maybe it is not good enough? I like this stuff though and making it is extremely creative honestly: Do ignore my avatars, as they are simple, only there for putting stuff into the right påositions. Some say my Avatars just looks scary. It was a fast, filthy, quick make, nothing else. So ignore my character but peek at the objects. https://pepromusdesign.blogspot.com/

So the video where he gives me more positive Reviews. I did a retexture of the Redoran buildings, as I suddenly felt they would fit wooden. Well honestly, they do not really. We did make so much not LORE friendly stuff. But never mind that. It really made it look nice and that is what counted 2005 :D Wood is only used in buildings at the coast lines in Morrowind. There are no wood, except there. So wooden Redoran structures really do not make sense at all when we think about it. That is what I try to do today, think about more steps, than just make stuff look good. It should be realistic. This is not: :D The narrator does not seems to care either about it... :wink:

We made so much stuff that where not Lore friendly and the player still make so much none Lore friendly stuff :D Well honestly, we can make whatever we want really. Do we must follow the lore? I try to that today really.

What where we debating really? Yes, Globals... :wink: I might cheat and I will if I fail to make a quest and store my Variables there. But honestly, I want it simple. The quest + 2 Booleans, will take more RAM than the 2 Globals will do and they WILL remain in RAM, no matter what. I should not be ashamed to use a Global honestly but it really got deep rooted into my mind, never use a Global. But do not show it to Maskar if I do... :wink: Well we debate cooperating stuff, lets see where we end up. I made a lot of stuff to the next version of his brilliant MOO at least and I will really make a video today, how I use MOO, combining it with my own project, as I made an addon for it. Yes, I will. :D That sound fun.

When I started coding, 1987, Line basic, there where no such things as Global or Local variables. It was variables. We never had to declare anything or give variables proper names as there was not enough RAM for it. We use single letters as variables and I see some of you use that nasty habit too. A variable should have a proper name, that informs any coworker or anyone reading the code what the purpose of that specific variable really is. This is also from that specific book. C for Dummies. :D Damn, I really love that book. So damn good, well every damn DUMMIE book is good reading. :D Best series ever made for Computer users. I also read ano the C book, more complicated. It could also be that book that told me about misusing Globals, and good coding practices as we can really code in so many different ways, and still get the same result. The author did write, that is a big Problem. It makes it impossible for others to debug.

I will use 2 GLOBAL Booleans :D Honestly, it is not that bad really... :wink: We are not professionals really... Are we? Nope, we are not. Does everyone knows about this? Nope. Do they care? Nope... :wink: Edited July 17, 2022 by Pellape

[Pellape]

I found this about AlienSlof by the way. Damn, she is good :D

 

 

She does mention a friend in the beginning of that Interview. It was Qarl, our mentor and modding teacher for Morrowind and Oblivion. Without Qarl, I would not sitting here really either, nor AlienSlof. he did solve so much stuff for oblivion. We where so frustrated 2006. I almost left modding, it was that frustrating 2006, but today it feels so easy to do it. Qarl told us all to relax and take one step in a time really and he showed us every thing he did discover and how to change and mod it. So I am very grateful for Qarl and so is of course AlienSlof. :D lets see if she mention Qarl by name really. It is not about Qarl anyway, as it is about AlienSlof.

 

Qarl introduced me into 3D, into Blender. And honestly, that tool fits me perfect. It feels natural to me to create 3D stuff and I do not claim I am good at it really, but it makes me happy at least and makes me feel constructive. That is the only thing that counts honestly. :D Beeing Happy. :D

 

Can a sinle modder like Qarl really be that imoprtant? Yes. He made the first good Looking retexture for Oblivion and I still use it. I would not be here at all if it was not for him. I cannot say he would have made any difference for the Skyrim Community as he did pass away 2011, before Skyrim was released, but I really guess he would have contributed in some way. I am convinced of that. :D He did share so much stuff with the rest of us, as he did test new stuff, showing us how he did it in every detail. I loved following his WIP's every day and no one inspired me so much. :D It was a fun journey...

 

AlienSlof did make some odd stuff, and I cannot say I love all she made as some stuff is really nasty. But I am not a jusge honeslty. We can do anything we want in the TES world. It can fullfill everyones dreams. We are all different, no doubt. She really share stuff with us, that makes me blush sometimes... :wink: She is not shy about who she really is. :wink: I cannot say I did enjoy all screenshots she made honestly. She did fullfill her inner dreams. Many is doing the same today but i guess she or Canadian Ice was the first ones doing it. I was a big fan of Canadian Ice. She did stop making stuff 2005 already. Thats a shame as she was so good, but sill. She is a good friend now. She is making dolls and dolls clothing and that makes her happy. That is what is most important. We must all stay Happy and have fun. :D I did follow AlienSlofs all WIP's as well, not that I got inspired of them personally, but still. For me it was good art but it made me blush for sure. ;)

Edited July 17, 2022 by Pellape

[Pellape]

About RAM. Today RAM is not an issue really. We have enough. It has not always been like that.

 

The most common bug programs has is Memory Leaking. I do not know how to prevent it. I do not actually know if my programs I made are clean, not that I really made many but I made some, in both C and also Visual Basic. Where are they? Well not available any longer for sure. I did search for them as I needed at least one again. It was not common back then around 1990-1995 to upload stuff to Internet and if I did, well I did save some stuff at my local ISP and that is good as long as I used that ISP. :smile: Common share sites is best of course, to make stuff available forever.

 

Those 2 books teach us how to declare variables, but not to undeclare them. I do not even know if that is needed really. I do know that in OBSE, we must Destruct the strings, if we use them or they will cause a Bloat. making the saving of the game take a very very longtime, making the *.obse save files to increase forever and if we open a bloated file, it will have the strings there as text, so we can actually back trace the source easy, that is good. I do think that the OS will take care of all variables when they are used and remove them from RAM when they are not used. What happens when a program leaks really? I do not know. I do know it will cause a lot of LAG, and that the program will start to use more RAM then it is supposed to until there is no RAM left, until the Comp starts to use up all Virtual RAM, then the comp will finally stall. This did worry me some and I have been thinking about it a lot. The books do not say how to prevent it.

 

Another thing that really bothers me with C, and I am not alone as it confuses so many, our C teacher told me, it is when to use the info inside a declared variable and then when to use a pointer only. It is also described in my 2 C books, but that does not make me sure honestly. This is not something we need to know when Scripting TES but we do use it, never the less, as TES scripting and C looks almost identical. The property as one example is a pointer as it points to the reference and it is the reference that takes up space in RAM and the pointer only point where it actually is. Okay, the pointer it self takes up a space in RAM as everything does of course.

 

In C, we declare a variable like this:

 

Int ThisBloodyVariable

 

If I want to just get the info from it, I have to use the pointer: The pointer in this case is: ThisBloodyVariable* and we can also point to the pointer like this ThisBloodyVariable**... Well - Make my day, as when ever do we actually need to make apointer to the pointer? Well it is possible never the less but I never seen it used. :wink: I never get it straight, so when I compile my stuff and it does not work and trace it and I do not figure out why it does not work, I just add a bloody * to the variable I suspect and it works. Maybe I could understand it better today really. Trial and Error rocks however. :D The thing is with all error messages we get in C, is that it always points to the wrong line. Mostly it points to line 345, when the actual error is at line 346... :wink: So bloody annoying and also stupid. :D I did see that in TES 5 as well, the papyrus Compiler. In Oblivion, it always complain about the right line. The error is at line 318 and it really is. I love the editor inside CSE, but I still use Notepad++ but honestly, do I really need that? It all depends. The developer of CSE should really remake CK... :D Just peek at it: https://www.nexusmods.com/oblivion/mods/36370

 

Here is a screenshot of the editor:

 

 

So with an editor like that one, with all settings we can do inside it, the use of external editors is really obsolete but it is up to each and everyone really. I am so used to Notepad++ as it has some features that I really love. So why has no one made it for Skyrim? Well maybe someone will, specially now when CK is free. Maybe the development of https://www.nexusmods.com/skyrimspecialedition/mods/20061 will be the way to go? If they continue?

 

It is filled with Filters, and it is so easy to find stuff in Oblivion with CSE. I do miss many of its features in CK... It really makes life easier. :D

 

 

So how or what does cause memory leaking then? I do not know really. :wink: I do know even MS had such issues in Office and it can be bugs made by RAM makers or whatever, maybe even a bug in the CPU. I do not know. Can it be misuse of Globals? I do not know.

Edited July 17, 2022 by Pellape

[Pellape]

About Inigos riding issue? Well the soution is here: https://forums.nexusmods.com/index.php?/topic/5060355-inigo/page-657&do=findComment&comment=91314038

I will try it tomorrow. It is only if we use SKSE64, RaceMenu and Inigo together, and we remove something from his inventory, this bug occur.

 

Maybe it would be enough to remove RaceMenu? Well honestly, I do not dare to remove anything as we should not remove mods in a current play game someone claimed. Maybe it is so? maybe not. Do not try to fix anything that actually is not broken. That's a golden rule. :D Well, Inigo is broken, and I did read it beforer installing him, but i forgot. Nowit is to late, I cannot roll him back, not without making a new game. :D Well does it really matter? Nope. It is just an immersive bug that feels a bit frustrating time to time, that's it. It is not like the game have crashed... ;)

[IsharaMeradin]

Careful fixing things mid-game. A mid-game fix is often times a band-aid on a larger issue. Furthermore, not every user will end up with the same set of mods that could lead to the issue needing to be fixed. Either keep these types of fixes to yourself or document the exact cause and reason for the fix to exist.

[Pellape]

Well I did mention my setup, what is causing the issue, the combination. I keep it there for now. I can remove it if it would cause an issue. I wait and see what Sphered thinks about it first, he is the one it is addressed to :D I could PM him as well. If I screw up my own save game, I will use a backup as i do not do it without backupping my own save files first. ;) That counts for everyone as well... ;) Always backup your files :D

Edited July 17, 2022 by Pellape