Pellape Posted January 28, 2021 Author Share Posted January 28, 2021 The Resurrect spell I am so stupid... My resurrect spell do make the game crash when I target containers, which I also warned about in my description and I really thought it was the command resurrect that made it crash. Look at these 2 rows... Message "You cannot resurrect that %n", TargetREF MessageEX "You cannot resurrect that %n", TargetREF So guess which one that it is that is crashing the game? Well not resurrect for sure. The ress spell works perfect now as I did find the problem last night but it wasn't obvious as I looked at the wrong place and row. Link to comment Share on other sites More sharing options...
DrakeTheDragon Posted January 28, 2021 Share Posted January 28, 2021 Yeah, for whatever the reason most CTDs come rather from the messaging functions using placeholders they shouldn't or values not fitting than anything else really. It's remarkably surprising how often it's simply a message that CTDs. Link to comment Share on other sites More sharing options...
Pellape Posted January 28, 2021 Author Share Posted January 28, 2021 I am so happy that I solved it as this was so damn frustrating. :D Link to comment Share on other sites More sharing options...
Oblivionaddicted Posted January 29, 2021 Share Posted January 29, 2021 (edited) I already showed you the script of a resurrect spell that doesn't CTD anyway. Edited January 29, 2021 by Oblivionaddicted Link to comment Share on other sites More sharing options...
Pellape Posted January 29, 2021 Author Share Posted January 29, 2021 (edited) Yes you did for sure and it looks almost the same but I also wanted to add messages in it so as I did focused at the Resurrect part, I made so many changes and changed the checks so now it do looks a loot different than it did from start and I could go back to the original checks but as it works, I keep it as it is now. I was so damn blind but I finally did Open my eyes. scn PekResurrectSCR Ref TargetREF Short Container Short NPCorCreature Begin ScriptEffectStart Set TargetREF to GetSelf Set Container to IsContainer TargetREF Set NPCorCreature to GetObjectType TargetREF If ( NPCorCreature == 23 ) MessageEX "It's not possible to Resurrect that %n", TargetREF Dispel PekResurrectSPL Return Endif End Begin ScriptEffectFinish If ( TargetREF.GetDead == 1 ) If ( NPCorCreature == 35 || NPCorCreature == 36 ) ;pme REHE TargetREF.Resurrect 1 MessageEX "%n is up and running again", TargetREF Endif Else MessageEX "It's not possible to Resurrect that %n", TargetREF Endif Dispel PekResurrectSPL End So no matter which check I did use, the checks did work, like iscreature, isactor and crashed when I used message "%n", TargetRef, instead of MessageEX "%n", TargetRef - Open your eyes and discover... :wink: So damn cool text made by John Andersson. Edited January 29, 2021 by Pellape Link to comment Share on other sites More sharing options...
Pellape Posted February 2, 2021 Author Share Posted February 2, 2021 (edited) Entering the Hallway - The door to the library is not added yet.A new texture at the stairs and also a new UV that I think went out very well. Looks better than I had expected. I do need to fix that light in the right stair that leads to the staffs areas... TO BRIGHTThe door to the Display room. The door frame is more fat than any frames in WoW... :wink: We might just can call that corner for Mazoogas corner. Could put a bed there for her... :wink: In case she drops by... Edited February 2, 2021 by Pellape Link to comment Share on other sites More sharing options...
Pellape Posted February 4, 2021 Author Share Posted February 4, 2021 (edited) 2 things I wanna do right now. The Bottle RackI was a bit lazy when I made the Bottle Rack filler but I did ran into so many problems making it so now it is time to make it perfect. When each bottle get added, the collisions disturbs the other bottles and they get all moved around slightly and it do look a bit sloppy. I will add a bottle database where all bottles coordination's will be added and a script will check if the bottle do exist in the cell or not and will move every damn bottle in the right place during a single frame inside a loop. If it will not work, I can always keep the sloppy script. I am not a pedant but I do like to make stuff perfect, well as perfect as possible. :wink: LootingI did made a Looting container spell but now I want to take a step further as I have been using d4v3's damn cool Book Looting spell and he also wrote in the description that we can do what we want with it :D YES!!!! I am so bloody lazy these days... Well I have been looting stuff now manually for 25 years, back and forth and is it fun to loot? No it is BOOOORING. I cannot resist picking all junk up, it is impossible as I am a bloody junkie, well in game at least as the items are placed there in every cell for me to pick them up. :wink: And I do love to see all stuff getting sold in the shop mod even if the shop is a fake, it does add immersion as it is good RP after all to be a shopkeeper, the richest one in game. :D Well we can always just do a player.additem f 1000... instead but that really breaks immersion - A lot. A good mage, well any mage should be able to pick up or do whatever he wants with any item with magic. But I am an marksman, a magical marksman... :wink:All loot spells will be Alteration Novice. Edited February 4, 2021 by Pellape Link to comment Share on other sites More sharing options...
Pellape Posted February 4, 2021 Author Share Posted February 4, 2021 (edited) Reading others scripts is so damn nice as all modder's do script in their own ways, and some do have more brilliant solutions than others for sure and when I learn new things it feels so damn good. :D Edited February 4, 2021 by Pellape Link to comment Share on other sites More sharing options...
Pellape Posted February 5, 2021 Author Share Posted February 5, 2021 (edited) Dynamic Item and chest sorterSmart chests with memory of an old elephant My laziness will take me a step further. I will make a dynamic Item sorter. We do have alchemy sorter and now I have fully working looting spells, so my inventory is more filled at the moment than ever before. Players that use the Hobbit home have most likely started to use different containers for different things and I will not change their ways of how they sort their stuff. So a quest will check each container added to this sorter. Well lets make a list of what will be needed.A questscript that will containChestsItems added to different chestsA spell to add chests to the questA spell that removes chests from the questA chest where you can add items that you do no longer want to be sortedA spell to start the sortingA button to start the sorting or maybe a fancy sorting station? Well lets see about that...Anything else that I should think about? So the first time before the sorter can be used on an empty container, well any container no matter where in Nirn it is placed, well not in Morrowind nor Skyrim though, but at least in Oblivion, the game we do play, you need to add the item by hand - By hand?? Well yes, by hand at least ones. But I am to lazy for even open a single chest, as I do want the sorter to work immediately!! Oki, go to Skyrim and use the static sorters provided by the Legacy of the Dragonborn, they have static sorters. :wink: I was on my way to make a dynamic sorter for ef's Ultimate Shopkeeper Mod 2020 but then I thought, why limit it and why add scripts to chests? Why clog up the already heavy scripted home with scripts on every chest as I do have a lot of them and I do add more the deeper I go into the ground towards the new Library and beyond. So the smartest way to handle it is with a quest, with low priority and dynamic speed. Well with loops I do not need to change the speed. I do not even store my resources for crafting in the Hobbit House, as I added a cabin outside it, from MOO and I store them in a homemade crafted chest added by MOO and it is in that cabin all crafting tools are placed as well. So I add the resources direct to those crafting stations immediately anyway as they are containers after all. So much sorting every day... So many containers... Some containers I have, well at least 6, have unique stuff like stuff we get when we complete quests that later will be part of the Museum and other stuff I want to have displayed later on. So do store unique stuff as sooner or later, you will find that a special spot will be added for it, a display of some sort, somewhere deeper under ground. I always wondered when I played Skyrim. Why is the sorters so damn slow in The Legacy of the Dragonborn? Everything is slow. It takes a minute or more to sort stuff and even more to scan the museum and it sure made me impatient, sitting there glaring at the bloody screen, waiting in an eternity. Just look at the alchemy sorter in COBL, most likely made by Wrye which is the fastest alchemy sorter I ever used. This is the speed I want in my new sorter but as I need to compare arrays with each others, that speed will not be possible I guess but never as slow as in that Skyrim mod for sure. It was the same when scanning for new quests. It took forever, sometimes 5 minutes until the scanning stopped and informed you that it failed... :wallbash: Edited February 5, 2021 by Pellape Link to comment Share on other sites More sharing options...
Pellape Posted February 6, 2021 Author Share Posted February 6, 2021 I will also add 2 small specific containers.One where you put items to be deleted from the sorting database One that will allow you to keep 1 item in inventory but store the restSo why store an item in Inventory? I do use a chest for selling stuff in ef's Ultimate Shopkeeper Mod 2020 and I do want to sell all extra pickaxes or cooking pots I find but I really want to keep one. So you just add a Cooking pot and a pickaxe in that chest, and those 2 chests will be checked first before the sorting begins. The scripts are half done now. I do need many breaks from it as it do need me to think in circles when writing it. I am not good at multitasking, so when I need a break, I go here and write some no sense... ;) I also want the code to be as optimized as possible. I think breaks is also good to take as then it allows me to get new ideas and sometimes... -> Why did I not think about this and that? Any other things I should think about? Link to comment Share on other sites More sharing options...
Recommended Posts